Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip: Remove unused option use_mirrors and remove all ignore.txt entries #58977

Merged
merged 2 commits into from Jul 18, 2019

Conversation

Projects
None yet
4 participants
@hannseman
Copy link
Contributor

commented Jul 11, 2019

SUMMARY

This PR removes the unused option use_mirrors. I've tried to find when this option was actually used but I couldn't find it, I guess it predates the current mono-repo? Anyway since this option hasn't been documented for at least the last 4 current major versions it should be alright to be removed.

Together with #58966 this allows us to remove all ignored sanity checks from ignore.txt. This PR will keep failing until #58966 is merged this branch is rebased.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pip

@hannseman hannseman changed the title pip: Remove unused option use_mirrors and remove all ignore.txt entries [WIP] pip: Remove unused option use_mirrors and remove all ignore.txt entries Jul 11, 2019

@hannseman hannseman closed this Jul 11, 2019

@hannseman hannseman reopened this Jul 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 11 errors:

lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'chdir' in argument_spec defines type as 'path' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'executable' in argument_spec defines type as 'path' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'extra_args' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'name' in argument_spec defines type as 'list' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'requirements' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'umask' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'version' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'virtualenv' in argument_spec defines type as 'path' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'virtualenv_command' in argument_spec defines type as 'path' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'virtualenv_python' in argument_spec defines type as 'str' but documentation doesn't define type

click here for bot help

@bcoca bcoca removed the needs_triage label Jul 11, 2019

@webknjaz

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

@hannseman this is ready for rebasing :)

@hannseman hannseman force-pushed the hannseman:pip-remove-use-mirrors branch from 31a8ad2 to a32695b Jul 13, 2019

@hannseman hannseman changed the title [WIP] pip: Remove unused option use_mirrors and remove all ignore.txt entries pip: Remove unused option use_mirrors and remove all ignore.txt entries Jul 13, 2019

@ansibot ansibot added core_review and removed WIP labels Jul 13, 2019

@hannseman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2019

Rebased and ready_for_review :)

@webknjaz webknjaz merged commit 0e8eb1d into ansible:devel Jul 18, 2019

1 check passed

Shippable Run 132045 status is SUCCESS.
Details
@hannseman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@webknjaz thanks for the review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.