-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip: Remove unused option use_mirrors and remove all ignore.txt entries #58977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannseman
changed the title
pip: Remove unused option use_mirrors and remove all ignore.txt entries
[WIP] pip: Remove unused option use_mirrors and remove all ignore.txt entries
Jul 11, 2019
ansibot
added
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
affects_2.9
This issue/PR affects Ansible v2.9
bug
This issue/PR relates to a bug.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
packaging
Packaging category
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
labels
Jul 11, 2019
The test
|
bcoca
removed
the
needs_triage
Needs a first human triage before being processed.
label
Jul 11, 2019
@hannseman this is ready for rebasing :) |
hannseman
force-pushed
the
pip-remove-use-mirrors
branch
from
July 13, 2019 20:01
31a8ad2
to
a32695b
Compare
hannseman
changed the title
[WIP] pip: Remove unused option use_mirrors and remove all ignore.txt entries
pip: Remove unused option use_mirrors and remove all ignore.txt entries
Jul 13, 2019
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
labels
Jul 13, 2019
Rebased and ready_for_review :) |
@webknjaz thanks for the review! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.9
This issue/PR affects Ansible v2.9
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
module
This issue/PR relates to a module.
packaging
Packaging category
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR removes the unused option
use_mirrors
. I've tried to find when this option was actually used but I couldn't find it, I guess it predates the current mono-repo? Anyway since this option hasn't been documented for at least the last 4 current major versions it should be alright to be removed.Together with #58966 this allows us to remove all ignored sanity checks from ignore.txt. This PR will keep failing until #58966 is merged this branch is rebased.
ISSUE TYPE
COMPONENT NAME
pip