Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use comprehensions rather than map() in container_to_bytes() and container_to_text() #58997

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Use comprehensions rather than map() in container_to_bytes() and container_to_text() #58997

merged 1 commit into from
Jul 12, 2019

Conversation

samdoran
Copy link
Contributor

SUMMARY

Since we now require Python > 2.6 on the controller, we can drop the use of map() here

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/common/text/converters.py

@samdoran
Use comprehensions rather than map()
ccd0e5a 
Since we now require Python > 2.6 on the controller, we can drop the use of map() here
@samdoran samdoran requested a review from abadger July 11, 2019 21:38
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 11, 2019
@abadger
Copy link
Contributor

abadger commented Jul 11, 2019

+1. Note that eventually we'll have to replace this with an iterative version instead of recursive. (because recursion can go too deep). Don't have to worry about it for now because we haven't had any bugs opened on this code.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 11, 2019
@samdoran samdoran merged commit dd30d86 into ansible:devel Jul 12, 2019
@samdoran samdoran deleted the map-to-comprehensions branch July 12, 2019 19:49
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Jul 15, 2019
@ansible ansible locked and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdoran @abadger @mkrizek @ansibot