get rid of Sphinx 2.1.2 errors #59001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozine
added
docs
ansibot
added
affects_2.9
webknjaz
approved these changes
Jul 11, 2019
jborean93
approved these changes
Jul 12, 2019
felixfontein
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Most of these code blocks currently look pretty ugly anyway, due to all the lexing error marks, see for example https://docs.ansible.com/ansible/devel/user_guide/windows_setup#delete-winrm-listener So lexing them with YAML+Jinja (which this PR probably does, since that's the default lexer IIRC) can't make it look worse :) For the long term, it might be better to fix the PowerShell lexer so that it accepts colons.
samccann
approved these changes
Jul 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #57709
Currently we pin the docs build to Sphinx 1.x. This PR makes all the changes necessary to run a clean
make webdocsusing Sphinx 2.1.2 on Python 3.7.3.Takes the same approach to fixing the PowerShell lexer concerns as https://github.com/ansible/ansible/pull/57508/files#diff-1653c8c6462362632397ce0e9c948610R405.
ISSUE TYPE
COMPONENT NAME
docs.ansible.com