Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ce_vrrp to fix a bug #59185

Merged
merged 3 commits into from
Jul 19, 2019
Merged

update ce_vrrp to fix a bug #59185

merged 3 commits into from
Jul 19, 2019

Conversation

yanzhangi
Copy link
Contributor

@yanzhangi yanzhangi commented Jul 17, 2019 •
edited

SUMMARY

Manages VRRP interface attributes on HUAWEI CloudEngine devices
When a parameter is of the bool type, for example: If the value is True or yes, an error is reported in the module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_vrrp.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 17, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @numone213 @xuxiaowei0512 @zengchen1024 @zhongjun2
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 17, 2019

@yanzhangi, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 17, 2019
yuandongx
yuandongx suggested changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@yuandongx yuandongx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed type

lib/ansible/modules/network/cloudengine/ce_vrrp.py
@@ -48,8 +48,7 @@
admin_ignore_if_down:
description:
- mVRRP ignores an interface Down event.
type: bool
default: 'no'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss type defined.
The blow is same as this.

@ansibot ansibot removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jul 18, 2019
@yuandongx
Copy link
Contributor

shipit

@yuandongx
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

Components

lib/ansible/modules/network/cloudengine/ce_vrrp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo numone213 xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): xuxiaowei0512
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 18, 2019
@yanzhangi
Copy link
Contributor Author

read_for_review

@yuandongxx
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 19, 2019
@ansibot ansibot merged commit e7c9c95 into ansible:devel Jul 19, 2019
@ansible ansible locked and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuandongx yuandongx yuandongx requested changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yanzhangi @ansibot @yuandongx @yuandongxx