Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create integration tests for ansible-doc #59418

Closed
mattclay opened this issue Jul 23, 2019 · 4 comments
Closed

Create integration tests for ansible-doc #59418

mattclay opened this issue Jul 23, 2019 · 4 comments
Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. has_pr This issue has an associated PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@mattclay
Copy link
Member

SUMMARY

Create integration tests for ansible-doc.

There are no dedicated integration tests for ansible-doc. The only integration test using ansible-doc is the collections test:

ansible/test/integration/targets/collections/runme.sh

Line 24 in 79eca9c

ansible-doc testns.testcoll.testmodule -vvv | grep -- "- normal_doc_frag"

The ansible-doc sanity test does provide some coverage for ansible-doc, however, that sanity test is intended to verify that content can be displayed with ansible-doc rather than be an exhaustive test of the program.

Also, the ansible-doc sanity test will soon be testing only a single version of Python (once #59416 is merged), which will leave additional gaps in test coverage that would be handled by integration tests.

ISSUE TYPE

Feature Idea

COMPONENT NAME

integration tests
@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 23, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jul 23, 2019
@bcoca
Copy link
Member

bcoca commented Jul 23, 2019

the --json option in 2.9 will make it a lot easier to verify content

@mattclay mattclay mentioned this issue Aug 8, 2019
Closed
@mattclay mattclay mentioned this issue Sep 17, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Apr 29, 2020

Files identified in the description:
None

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added the has_pr This issue has an associated PR. label Apr 29, 2020
@s-hertel
Copy link
Contributor

It looks like some more have been added since in 570aed0, 23ab8f3, 8eab113, etc.

@ansible ansible locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. has_pr This issue has an associated PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattclay @bcoca @ansibot @s-hertel