Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting documentation #59982

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Conflicting documentation #59982

merged 1 commit into from
Aug 2, 2019

Conversation

tperamun
Copy link
Contributor

@tperamun tperamun commented Aug 2, 2019

SUMMARY

The "mode" parameter is already 'push' by default, so "required: true" isn't necessary.

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@tperamun
Conflicting documentation
5afd3bd 
##### SUMMARY
The "mode" parameter is already 'push' by default, so "required: true" isn't necessary.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Aug 2, 2019

@tperamun, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 aws cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Aug 2, 2019
@samccann samccann merged commit 1b246d8 into ansible:devel Aug 2, 2019
@samccann
Copy link
Contributor

samccann commented Aug 2, 2019

Thanks @tperamun for the Ansible documentation fix!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 5, 2019
@ansible ansible locked and limited conversation to collaborators Aug 30, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 aws cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tperamun @ansibot @samccann @sivel @dagwieers