Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route53_info: add pagination support to list #60433

Merged
merged 1 commit into from
Dec 2, 2019
Merged

route53_info: add pagination support to list #60433

merged 1 commit into from
Dec 2, 2019

Conversation

bkmeneguello
Copy link
Contributor

SUMMARY

Add support for paginated results when lists returns more then 100 results

Fixes #49457

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

route53_info

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

cc @Etherdaemon
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

@bkmeneguello, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 aws cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 12, 2019
jillr
jillr suggested changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this patch @bkmeneguello, would like a small change in the implementation please.

lib/ansible/modules/cloud/amazon/route53_info.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 16, 2019
jillr
jillr reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update @bkmeneguello! Tests pass locally for me and this change looks good, but I should note I don't have a test env with a large amount of items readily available.
@IPvSean - would you be able to test with this patch and see if it resolves #49457 for you please?

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. and removed new_contributor This PR is the first contribution by a new community member. labels Aug 30, 2019
@bkmeneguello
Copy link
Contributor Author

Hi, I'm using this feature in my domain with more than 2k records and no problems at the moment. Could someone merge this PR?

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 2, 2019
jillr
jillr approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping @bkmeneguello, apologies for the delay.

@jillr jillr merged commit 6075536 into ansible:devel Dec 2, 2019
D3DeFi pushed a commit to D3DeFi/ansible that referenced this pull request Dec 8, 2019
@bkmeneguello @D3DeFi
route53_info: add pagination support to list (ansible#60433)
fcb2147
anshulbehl pushed a commit to anshulbehl/ansible that referenced this pull request Dec 10, 2019
@bkmeneguello @anshulbehl
route53_info: add pagination support to list (ansible#60433)
06ca04b
@ansible ansible locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 aws cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_review Updates were made after the last review and the last review is more than 7 days old. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

route53_facts can't return a list of max_items > 100
3 participants
@bkmeneguello @ansibot @jillr