Role dep cycle detection broken on Py3.7+ #61527
Labels
affects_2.13
bug
This issue/PR relates to a bug.
P3
Priority 3 - Approved, No Time Limitation
python3
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Comments
nitzmahone
added a commit
to nitzmahone/ansible
that referenced
this issue
Aug 29, 2019
* failing on 3.7+, needs proper cycle detection * see ansible#61527
|
Files identified in the description: If these files are inaccurate, please update the |
ansibot
added
affects_2.9
nitzmahone
added a commit
that referenced
this issue
Aug 29, 2019
* default collection support * playbooks run from inside a registered collection will set that collection as the first item in the search order (as will all non-collection roles) * this allows easy migration of runme.sh style playbook/role integration tests to collections without the playbooks/roles needing to know the name of their enclosing collection * disable default collection test under Windows * enable collection search for role dependencies * unqualified role deps in collection-hosted roles will first search the containing collection * if the calling role has specified a collections search list in metadata, it will be appended to the search order for unqualified role deps * disable cycle detection unit test * failing on 3.7+, needs proper cycle detection * see #61527
adharshsrivatsr
pushed a commit
to adharshsrivatsr/ansible
that referenced
this issue
Sep 3, 2019
* default collection support * playbooks run from inside a registered collection will set that collection as the first item in the search order (as will all non-collection roles) * this allows easy migration of runme.sh style playbook/role integration tests to collections without the playbooks/roles needing to know the name of their enclosing collection * disable default collection test under Windows * enable collection search for role dependencies * unqualified role deps in collection-hosted roles will first search the containing collection * if the calling role has specified a collections search list in metadata, it will be appended to the search order for unqualified role deps * disable cycle detection unit test * failing on 3.7+, needs proper cycle detection * see ansible#61527
samdoran
removed
the
needs_triage
anas-shami
pushed a commit
to anas-shami/ansible
that referenced
this issue
Sep 23, 2019
* default collection support * playbooks run from inside a registered collection will set that collection as the first item in the search order (as will all non-collection roles) * this allows easy migration of runme.sh style playbook/role integration tests to collections without the playbooks/roles needing to know the name of their enclosing collection * disable default collection test under Windows * enable collection search for role dependencies * unqualified role deps in collection-hosted roles will first search the containing collection * if the calling role has specified a collections search list in metadata, it will be appended to the search order for unqualified role deps * disable cycle detection unit test * failing on 3.7+, needs proper cycle detection * see ansible#61527
|
I'm having this on CPython 3.8.12. I guess it's not limited to PyPy. Abort happens here: https://github.com/python/cpython/blob/v3.8.12/Python/ceval.c#L691-L697 It seems more functions are being called when recursion error is being handled, because simple infinite recursions throw |
nitzmahone
added
affects_2.13
and removed
affects_2.9
|
As an update here, this is no longer an issue in Python 3.10. So at this point, it's only affecting Python 3.9. Although that's not to say we couldn't still catch this sooner, and not rely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SUMMARY
Ansible's role cycle "detection" relied on the fact that stack overflows were recoverable in Python < 3.7- they'd catch (any old) RuntimeError and display a fatal message that a cycle was detected. This no longer works in 3.7+, and instead results in a crash with SIGABRT.
The recursive role dependency loader needs to explicitly detect cycles. Until then, the unit test for the cycle case in
units.playbook.role.test_role.TestRole.test_load_role_with_metadatahas been commented out.ISSUE TYPE
COMPONENT NAME
role metadata
ANSIBLE VERSION
2.9.0dev0
CONFIGURATION
NA
OS / ENVIRONMENT
NA
STEPS TO REPRODUCE
uncomment the cycle unit test above, and run it on Py3.7+
EXPECTED RESULTS
success
ACTUAL RESULTS
fail with SIGABRT
The text was updated successfully, but these errors were encountered: