Synchronize ignores check mode

[dalevizo]

Issue Type:

Bug report

Ansible Version:

1.4

Environment:

Centos 5

Summary:

Synchronize module seems to ignore check mode flag even though supports_check_mode = True is set.

Steps To Reproduce:

Run a playbook with a synchronize action with --check
root@vader:ansible $ cat poppers-sync.yml
---
- hosts: doverc1
user: root
tasks:
- name: static dovecot conf files
synchronize: src=/tmp/ansible/files/poppers/dovecot/ dest=/tmp/dovecot/etc/dovecot/

root@vader:ansible $ /usr/bin/ansible-playbook poppers-sync.yml --check -v -v

Expected Results:

rsync should run with the --dry-run option

Actual Results:

rsync runs without the --dry-run

root@vader:ansible $ /usr/bin/ansible-playbook poppers-sync.yml --check -v -v
PLAY [doverc1] **************************************************************** 

GATHERING FACTS *************************************************************** 
<doverc1> REMOTE_MODULE setup  CHECKMODE=True
ok: [doverc1]

TASK: [static dovecot conf files] ********************************************* 
changed: [doverc1] => {"changed": true, "cmd": "rsync --delay-updates --compress --timeout=10 --archive --rsh 'ssh -i /root/.ssh/id_dsa -o StrictHostKeyChecking=no' --out-format='<<CHANGED>>%i %n%L' /tmp/ansible/files/poppers/dovecot/ root@doverc1:/tmp/dovecot/etc/dovecot/", "msg": ".d..t...... ./\n<f+++++++++ README\n<f+++++++++ antispam.sieve\n<f+++++++++ dovecot-dict-sql.conf.ext\n<f+++++++++ dovecot-ldap.conf.ext\n<f+++++++++ dovecot.conf\ncd+++++++++ conf.d/\n<f+++++++++ conf.d/10-auth.conf\n<f+++++++++ conf.d/10-director.conf\n<f+++++++++ conf.d/10-logging.conf\n<f+++++++++ conf.d/10-mail.conf\n<f+++++++++ conf.d/10-master.conf\n<f+++++++++ conf.d/10-ssl.conf\n<f+++++++++ conf.d/15-lda.conf\n<f+++++++++ conf.d/20-imap.conf\n<f+++++++++ conf.d/20-lmtp.conf\n<f+++++++++ conf.d/20-pop3.conf\n<f+++++++++ conf.d/90-acl.conf\n<f+++++++++ conf.d/90-plugin.conf\n<f+++++++++ conf.d/90-quota.conf\n<f+++++++++ conf.d/90-sieve.conf\n<f+++++++++ conf.d/auth-checkpassword.conf.ext\n<f+++++++++ conf.d/auth-deny.conf.ext\n<f+++++++++ conf.d/auth-ldap.conf.ext\n<f+++++++++ conf.d/auth-master.conf.ext\n<f+++++++++ conf.d/auth-passwdfile.conf.ext\n<f+++++++++ conf.d/auth-sql.conf.ext\n<f+++++++++ conf.d/auth-static.conf.ext\n<f+++++++++ conf.d/auth-system.conf.ext\n<f+++++++++ conf.d/auth-vpopmail.conf.ext\n", "rc": 0}

PLAY RECAP ******************************************************************** 
doverc1                    : ok=2    changed=1    unreachable=0    failed=0   

[jctanner]

@dalevizo thanks for the report. Should be fixed in devel now.

[dalevizo]

Yes I confirm it's working.
Thank you.
Στις 25 Φεβ 2014 4:11 ΜΜ, ο χρήστης "jctanner" notifications@github.com
έγραψε:

@dalevizo https://github.com/dalevizo thanks for the report. Should be
fixed in devel now.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6155#issuecomment-36010354
.