Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme_* modules: deprecate acme_version default, announce that ACME v1 support will be deprecated eventually #61667

Merged
merged 7 commits into from
Sep 21, 2019
Merged

acme_* modules: deprecate acme_version default, announce that ACME v1 support will be deprecated eventually #61667

merged 7 commits into from
Sep 21, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Since everyone should use ACME v2 eventually, having acme_version default to 1 is not a good idea anyway.

I also added an announcement in the acme_version documentation that ACME v1 support will eventually be deprecated. Right now, people might still use it, but Let's Encrypt will shut it down eventually (current plan: less than two years from now), and also other CAs should migrate to ACME v2 eventually (assuming that our implementation actually works with their ACME v1 implementation at the moment).

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/acme.py
acme_account
acme_account_info
acme_certificate
acme_certificate_revoke
acme_inspect

@ansibot
Copy link
Contributor

ansibot commented Sep 1, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @mgruener @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 1, 2019
@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 3, 2019
acozine
acozine reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement overall. I see a few ways it could be made even better.

lib/ansible/plugins/doc_fragments/acme.py Show resolved Hide resolved
lib/ansible/plugins/doc_fragments/acme.py Show resolved Hide resolved
lib/ansible/plugins/doc_fragments/acme.py Outdated Show resolved Hide resolved
@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Sep 3, 2019
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 3, 2019
@samccann
Copy link
Contributor

recheck

@samccann
Copy link
Contributor

Closing and reopening to see if that kickstarts shippable

@samccann samccann closed this Sep 13, 2019
@samccann samccann reopened this Sep 13, 2019
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 13, 2019
@felixfontein
Copy link
Contributor Author

Rebased to remove conflict with merged #61648.

resmo
resmo approved these changes Sep 21, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo resmo merged commit a7b2397 into ansible:devel Sep 21, 2019
@felixfontein felixfontein deleted the acme-version-2 branch September 21, 2019 13:17
@felixfontein
Copy link
Contributor Author

@acozine @samccann thanks for reviewing and your suggestions!
@resmo thanks for reviewing and merging!

anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@felixfontein @anas-shami
acme_* modules: deprecate acme_version default, announce that ACME v1…
a7d34dc 
… support will be deprecated eventually (ansible#61667)
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. pr_day Has been reviewed during a PR review Day support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@felixfontein @ansibot @samccann @resmo @acozine @gundalow