Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ce_stp to fix bugs #61774

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Update ce_stp to fix bugs #61774

merged 1 commit into from
Sep 18, 2019

Conversation

yanzhangi
Copy link
Contributor

SUMMARY

Modify the configured query statement and replace get_config with exec_command

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

ansible/lib/ansible/modules/network/cloudengine/ce_stp.py

@ansibot
Copy link
Contributor

ansibot commented Sep 4, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @xuxiaowei0512 @zengchen1024 @zhongjun2
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 4, 2019

@yanzhangi, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. labels Sep 4, 2019
yuandongx
yuandongx approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@yuandongx yuandongx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yuandongxx
Copy link
Contributor

+1

@yuandongxx
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Sep 5, 2019

Components

lib/ansible/modules/network/cloudengine/ce_stp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): xuxiaowei0512 hwDCN
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Sep 5, 2019
@yuandongx
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Sep 5, 2019

Components

lib/ansible/modules/network/cloudengine/ce_stp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): xuxiaowei0512 hwDCN
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot added automerge This PR was automatically merged by ansibot. and removed automerge This PR was automatically merged by ansibot. labels Sep 13, 2019
@yuandongxx
Copy link
Contributor

bot_status

1 similar comment
@yuandongxx
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

Components

lib/ansible/modules/network/cloudengine/ce_stp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): xuxiaowei0512 hwDCN
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot merged commit 466c3e6 into ansible:devel Sep 18, 2019
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@yanzhangi @anas-shami
Update ce_stp to fix bugs (ansible#61774)
ac9b7ca
@ansible ansible locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuandongx yuandongx yuandongx approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. networking Network category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yanzhangi @ansibot @yuandongxx @yuandongx