Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should validate-modules sanity test treat module_utils in collections? #62496

Closed
webknjaz opened this issue Sep 18, 2019 · 6 comments
Closed
Labels
affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@webknjaz
Copy link
Member

webknjaz commented Sep 18, 2019

SUMMARY

When a module in a collection contains something like from ansible_collections.new_azure_order.azure.plugins.module_utils.azure_rm_common import AzureRMModuleBase, sanity tests report:

ERROR: Found 1 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/azure_rm_webappslot.py:0:0: missing-module-utils-import: Did not find a module_utils import
ISSUE TYPE
  • question?
COMPONENT NAME

ansible-test

ADDITIONAL INFORMATION

N/A

@webknjaz webknjaz created this issue from a note in Testing Collections (To do) Sep 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

@webknjaz: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE.md

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 18, 2019
@sivel
Copy link
Member

sivel commented Sep 18, 2019

We'll likely just need to toggle different logic when self.collection at the following place in the code

if [n for n in names if n.startswith('ansible.module_utils')]:

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 19, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 2, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@rambleraptor
Copy link
Contributor

Running into this same issue with the Google collection!

@mattclay
Copy link
Member

Resolved by #63932

Testing Collections automation moved this from To do to Done Oct 30, 2019
@ansible ansible locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
Development

Successfully merging a pull request may close this issue.

6 participants