Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check_args from nxos #62625

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Remove check_args from nxos #62625

merged 2 commits into from
Sep 26, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Sep 19, 2019 •
edited

SUMMARY

check_args does nothing, and hasn't for many releases.

See also: #62623

ISSUE TYPE
  • Feature Pull Request?
COMPONENT NAME

nxos

@Qalthos Qalthos mentioned this pull request Sep 19, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

cc @GGabriele @chrisvanheuveln @jedelman8 @mikewiebe @privateip @rahushen @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

@Qalthos, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 19, 2019
@Qalthos Qalthos merged commit 8b9c253 into ansible:devel Sep 26, 2019
@Qalthos Qalthos deleted the remove_check_args_nxos branch September 26, 2019 19:02
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 1, 2019
@ansible ansible locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Qalthos @ansibot @sivel