Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in nxos_config documentation #62629

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Fixed typo in nxos_config documentation #62629

merged 1 commit into from
Oct 7, 2019

Conversation

contemno
Copy link
Contributor

@contemno contemno commented Sep 19, 2019

SUMMARY

Changed 'exit' to 'exist' and removed unnecessary word 'first'

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@contemno contemno changed the title Fixed typo Fixed typo in Documentation Sep 19, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

@contemno, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. nxos Cisco NXOS community small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 19, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_config.py:201:90: W291: trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 19, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2019
@acozine
Copy link
Contributor

acozine commented Sep 30, 2019

@contemno thank you for the contribution! Sphinx has strict rules about whitespace, and that's making your PR fail on our CI system right now. If you accept/approve @Akasurde's suggestion, that will fix the CI failure, and then we can merge this PR.

If you have any questions, feel free to join the #ansible-docs channel on Freenode IRC.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 30, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Oct 1, 2019
* Changed 'exit' to 'exist'
* Removed unnecessary word 'first'
@Akasurde Akasurde changed the title Fixed typo in Documentation Fixed typo in nxos_config documentation Oct 7, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 7, 2019
@Akasurde Akasurde merged commit 0554b50 into ansible:devel Oct 7, 2019
@Akasurde
Copy link
Member

Akasurde commented Oct 7, 2019

@contemno Thanks for the contribution.

acozine pushed a commit to acozine/ansible that referenced this pull request Oct 8, 2019
* Changed 'exit' to 'exist'
* Removed unnecessary word 'first'

(cherry picked from commit 0554b50)
@acozine acozine mentioned this pull request Oct 8, 2019
acozine added a commit that referenced this pull request Oct 9, 2019
* Fixing typo mistake in testbed with section. Deploy template from content library is supported from 67U3

(cherry picked from commit c6c13b5)

* Typo fix in mssql_db (#63184)
Changed from 'then' to 'than'

(cherry picked from commit b5cc087)

* VMware: Update maintenance notes on vmware_cfg_backup (#62853)
Maintenance mode seems only to be required for load or restet, not for save_configuration. 

(cherry picked from commit e977e0a)

* Misc typo in nxos_config documentation (#62629)
* Changed 'exit' to 'exist'
* Removed unnecessary word 'first'

(cherry picked from commit 0554b50)

* postgresql: add elements for list params to the module's documentation (#63186)

(cherry picked from commit 8a37a24)

* mysql: add elements for list params to the modules' documentation (#63187)

(cherry picked from commit 30c2d21)

* Add spaces around {{ indicators. (#63125)
The example looked a little less readable by not having spaces after `{{` and before `}}`. This commit should make the examples match [ansible-lint rule 206](https://github.com/ansible/ansible-lint/blob/master/lib/ansiblelint/rules/VariableHasSpacesRule.py)

(cherry picked from commit b7a9d99)

* fix typo in collection/plugins/readme (#63162)

(cherry picked from commit da1a945)

*  Docs: User guide overhaul, part 1 (#63056)

(cherry picked from commit 941a9b6)
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. nxos Cisco NXOS community small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants