Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: add new module vmware_guest_tools_info #62860

Merged
merged 4 commits into from
Nov 11, 2019
Merged

VMware: add new module vmware_guest_tools_info #62860

merged 4 commits into from
Nov 11, 2019

Conversation

Tomorrow9
Copy link
Contributor

SUMMARY

Add a new module "vmware_guest_tools_info" to gather installed VMware tools related info.

#60258

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_guest_tools_info

ADDITIONAL INFORMATION
"vmtools_info": {
        "changed": false, 
        "failed": false, 
        "vmtools_info": {
            "vm_guest_fullname": "Red Hat Enterprise Linux 7 (64-bit)", 
            "vm_guest_hostname": "test-vm", 
            "vm_guest_id": "rhel7_64Guest", 
            "vm_hw_version": "vmx-10", 
            "vm_ipaddress": "10.10.10.10", 
            "vm_moid": null, 
            "vm_name": "test-rhel7.4", 
            "vm_tools_install_status": "toolsOk", 
            "vm_tools_install_type": "guestToolsTypeOpenVMTools", 
            "vm_tools_last_install_count": 0, 
            "vm_tools_running_status": "guestToolsRunning", 
            "vm_tools_upgrade_policy": "manual", 
            "vm_tools_version": 10277, 
            "vm_tools_version_status": "guestToolsUnmanaged", 
            "vm_use_instance_uuid": false, 
            "vm_uuid": null
        }
    }

This was referenced Sep 26, 2019
Closed
Closed
@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2019

cc @Akasurde @goneri @lparkes @pgbidkar @warthog9
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cloud community_review In order to be merged, this PR must follow the community review workflow. has_issue module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Sep 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:0:0: module-incorrect-version-added: version_added should be '2.10'. Currently 2.1

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:115:62: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:116:37: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:117:43: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:118:35: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:119:39: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:120:30: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:121:46: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:122:54: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:123:42: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:124:56: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:125:45: W291: trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:126:35: W291: trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. ci_verified Changes made in this PR are causing tests to fail. labels Sep 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:0:0: module-incorrect-version-added: version_added should be '2.10'. Currently 2.1

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed ci_verified Changes made in this PR are causing tests to fail. labels Sep 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 27, 2019

@GBrawl @MikeKlebolt @alongchamps @bedecarroll @CastawayEGR @chrrrles @dav1x @davidmhewitt @dx0xm @equelin @garbled1 @GyorgyPeter @imjoseangel @jjahns @kamsz @karstenjakobsen @kryptsi @lrivallain @michaeldeaton @n3pjk @nafpliot-ibm @nerzhul @oboukili @pgbidkar @ritzk @rmin @stravassac @sumkincpp @vmwjoseph @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 27, 2019
goneri
goneri suggested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes, otherwise the module looks good to me. Thanks @Tomorrow9!

lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py Outdated Show resolved Hide resolved
@goneri goneri requested a review from Akasurde October 1, 2019 13:48
@ansibot ansibot removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Oct 5, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 5, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 15, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 15, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_tools_info.py:0:0: module-incorrect-version-added: version_added should be '2.10'. Currently 2.1

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Oct 15, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Oct 15, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Oct 23, 2019
@Tomorrow9
Copy link
Contributor Author

Hi @goneri, @Akasurde, I've changed as your comments, would you please take a look and approve? Thanks a lot.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 10, 2019
@Akasurde Akasurde merged commit 0d851dd into ansible:devel Nov 11, 2019
@Akasurde
Copy link
Member

@Tomorrow9 Thanks for the contribution.

@ansible ansible locked as resolved and limited conversation to collaborators Nov 11, 2019
@Tomorrow9 Tomorrow9 deleted the fix_pr60258_new branch November 12, 2019 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goneri goneri goneri requested changes

@Akasurde Akasurde Awaiting requested review from Akasurde

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud has_issue module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_review Updates were made after the last review and the last review is more than 7 days old. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tomorrow9 @ansibot @Akasurde @goneri