Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed capitals vSphere #62975

Merged
merged 1 commit into from
Oct 1, 2019
Merged

changed capitals vSphere #62975

merged 1 commit into from
Oct 1, 2019

Conversation

servisan
Copy link
Contributor

@servisan servisan commented Sep 30, 2019 •
edited

SUMMARY

Changed VSphere to vSphere in comment

@ansibot
Copy link
Contributor

ansibot commented Sep 30, 2019

cc @Akasurde @Tomorrow9 @dagwieers @goneri @lparkes @pgbidkar @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 30, 2019

@servisan, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Sep 30, 2019
goneri
goneri suggested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the code comments. Could you also add an entry for vSphere in the nomenclature section here:

https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/dev_guide/platforms/vmware_guidelines.rst#nomenclature

@goneri
Copy link
Contributor

goneri commented Sep 30, 2019

I see the same typography in:

  • lib/ansible/modules/cloud/vmware/vsphere_file.py
  • contrib/inventory/vmware_inventory.py

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Sep 30, 2019
@goneri
Copy link
Contributor

goneri commented Sep 30, 2019

Please, merge #62976 #62977 and #62978 in this PR.

This was referenced Sep 30, 2019
Closed
Closed
Closed
dagwieers
dagwieers approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagwieers dagwieers merged commit f102705 into ansible:devel Oct 1, 2019
@ansible ansible locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goneri goneri goneri requested changes

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@servisan @ansibot @goneri @dagwieers