Integration tests for s3_logging

[tremble]

SUMMARY

SSIA: add integration tests from s3_logging
The tests are pretty basic, it doesn't provide any form of output beyond returning changed

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

lib/ansible/modules/cloud/amazon/s3_logging.py
test/sanity/ignore.txt
hacking/aws_config/testing_policies/storage-policy.json

ADDITIONAL INFORMATION

Depends on mattclay/aws-terminator#65

[ansibot]

cc @mattclay @wimnat
click here for bot help

[ansibot]

@tremble, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[jillr]

The tests pass when I run them locally against CI but are failing in shippable, will have to dig into this more.

[jillr]

Looks like the CI failures are related to eventual consistency. Adding pauses for the specified times at the noted locations in the test seemed to be working.

need test changes

[tremble]

The tests pass when I run them locally against CI but are failing in shippable, will have to dig into this more.

Out of curiosity, which region do you 'locally' test on. I was running in us-west-2 and had no problems...

[jillr]

The tests pass when I run them locally against CI but are failing in shippable, will have to dig into this more.

Out of curiosity, which region do you 'locally' test on. I was running in us-west-2 and had no problems...

@tremble, also us-west-2 but it was showing up intermittently - if CI hadn't failed I would have probably missed it to be honest. I have a simple bash script I use for things like this that loops 50x over a test and once I started looping this one it was coming up maybe 1 in 5 times, roughly.

[jillr]

Hm, still getting occasional failures when looping at:

TASK [s3_logging : Enable logging] *********************************************
fatal: [testhost]: FAILED! => {"changed": false, "msg": "You must give the log-delivery group WRITE and READ_ACP permissions to the target bucket"}

These tests are likely to be unstable as-is, will need to dive into this again as the pauses might not be what we need after all.

[jillr]

shipit