Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_replication: add resetmaster choice to mode param #63321

Merged
merged 1 commit into from
Oct 10, 2019
Merged

mysql_replication: add resetmaster choice to mode param #63321

merged 1 commit into from
Oct 10, 2019

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Oct 10, 2019 •
edited

SUMMARY

mysql_replication: add resetmaster choice to mode param
fixes: #42870

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/database/mysql/mysql_replication.py

EXAMPLE
- name: >
     Run RESET MASTER command which will delete all existing binary log files
     and reset the binary log index file on the master
   mysql_replication:
     mode: resetmaster

@Andersson007 Andersson007 mentioned this pull request Oct 10, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Oct 10, 2019

cc @Alexander198961 @Xyon @banyek @bmalynovytch @bmildren @kurtdavis @michaelcoburn @Oneiroi @tolland
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. database Database category feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. mysql needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Oct 10, 2019
@Andersson007 Andersson007 force-pushed the mysql_replication_reset_master branch 3 times, most recently from a19f426 to 7957d09 Compare October 10, 2019 07:07
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 10, 2019
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 10, 2019
@Andersson007
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 10, 2019
@Andersson007 Andersson007 changed the title mysql_replication: add resetslave choice to mode param mysql_replication: add resetmaster choice to mode param Oct 10, 2019
bmalynovytch
bmalynovytch approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@bmalynovytch bmalynovytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Oct 10, 2019
@Andersson007
Copy link
Contributor Author

@bmalynovytch thank you! :)

resmo
resmo approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo resmo merged commit 3e87429 into ansible:devel Oct 10, 2019
@Andersson007
Copy link
Contributor Author

resmo: thank you for reviewing and merging!

@Andersson007 Andersson007 mentioned this pull request Oct 11, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@bmalynovytch bmalynovytch bmalynovytch approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 database Database category feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. mysql shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql_replication: missing 'reset master' mode
4 participants
@Andersson007 @ansibot @resmo @bmalynovytch