Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the RESET MASTER syntax #56584

Closed
wants to merge 2 commits into from
Closed

Add support for the RESET MASTER syntax #56584

wants to merge 2 commits into from

Conversation

tersmitten
Copy link
Contributor

SUMMARY

Adds support for MySQLs RESET MASTER Syntax.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mysql_replication

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented May 17, 2019

cc @Xyon @banyek @bmalynovytch @bmildren @michaelcoburn @Oneiroi @tolland
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. database Database category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. mysql needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 17, 2019
@bmalynovytch
Copy link
Contributor

@tersmitten CI failed because you forgot to update the mode choices and add the new resetmaster option 🙂

ansible/lib/ansible/modules/database/mysql/mysql_replication.py

Line 214 in 99a543b

'getmaster', 'getslave', 'changemaster', 'stopslave', 'startslave', 'resetslave', 'resetslaveall']),

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 17, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 25, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 2, 2019

cc @Alexander198961
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 18, 2019

cc @Andersson007
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 8, 2019

cc @kurtdavis
click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 9, 2019
@Andersson007
Copy link
Contributor

can be closed via #63321

@gundalow gundalow closed this Oct 11, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 database Database category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. mysql needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tersmitten @ansibot @bmalynovytch @Andersson007 @gundalow