Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-ify config warning message #63349

Merged
merged 1 commit into from
Oct 10, 2019
Merged

text-ify config warning message #63349

merged 1 commit into from
Oct 10, 2019

Conversation

nitzmahone
Copy link
Member

SUMMARY

ensure that config warning messages are always wide strings

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 10, 2019
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Oct 10, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 10, 2019
@nitzmahone
Copy link
Member Author

unrelated infra failures/timeouts, merging

@nitzmahone nitzmahone merged commit b20a0f4 into ansible:devel Oct 10, 2019
nitzmahone added a commit to nitzmahone/ansible that referenced this pull request Oct 10, 2019
@nitzmahone
bring back text-ification from ansible#63349
889f559
@nitzmahone nitzmahone mentioned this pull request Oct 10, 2019
Merged
abadger pushed a commit that referenced this pull request Oct 10, 2019
@nitzmahone @abadger
[2.9 backport] config encode errors should not be fatal (#63311) (#63312
1ca6667 
)

* config encode errors should not be fatal (#63311)

* fixes #63310
* subset of fixes from #58638
* added warning on error

(cherry picked from commit 77de663)

* bring back text-ification from #63349
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nitzmahone @ansibot