Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'delete' parameter description in synchronize module #63450

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

njoerd114
Copy link
Contributor

@njoerd114 njoerd114 commented Oct 14, 2019

SUMMARY

the synchronize module's parameter "delete" deletes excluded directories and files as well.

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

##### SUMMARY
the synchronize module's parameter "delete" deletes excluded directories and files as well.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Oct 14, 2019

cc @tima
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. files Files category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 14, 2019
@Akasurde Akasurde changed the title Update synchronize.py Update 'delete' parameter description in synchronize module Oct 14, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Oct 14, 2019
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @samccann @acozine Can you please take a look ? Thanks

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 14, 2019
@samccann samccann merged commit da46800 into ansible:devel Oct 14, 2019
@samccann
Copy link
Contributor

Thanks @niklasbeinghaus for the Ansible documentation fix!

acozine pushed a commit to acozine/ansible that referenced this pull request Oct 15, 2019
…63450)



Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit da46800)
acozine added a commit that referenced this pull request Oct 16, 2019
* Update sros_config.py (#63132)

(cherry picked from commit b3deab4)

* add note about collection links (#63346)

(cherry picked from commit bdd0fac)

* Nosh module documentation update (#63303)
* detail the 'status' dictionary
* did not add individual descriptions, see nosh documentation for those
* sample: False not being rendered unless 'False' is quoted

(cherry picked from commit df28378)

* Move galaxy appendix info to a new Galaxy section (#63356)
* start galaxy docs restructure
* shared snippets in txt files
* moved all content to galaxy section

(cherry picked from commit ae265bc)

* Enter should be Italics as it is a menu option (#63441)

(cherry picked from commit 7a8c909)

* ini_file: remove incorrect documentation (#63394)

(cherry picked from commit ab249a4)

* Changed with_items to loop in VMware example (#63022)

(cherry picked from commit 876a2d5)

* ovirt update fetch_nested param doc (#63191)

(cherry picked from commit 0beab6b)

* Update 'delete' parameter description in synchronize module (#63450)

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit da46800)

* Update unarchive.py - Further clarify extra_opts (#58102)
Update the description in the options to help assist with what the module is looking for in the extra_opts.  #31873 alone is not enough since if you are not familiar with the option given in the example it may not be obvious that both elements are part of the same option instead of being two different options.

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
(cherry picked from commit e967060)

* ovirt_vm add warning about next run configuration (#63458)

(cherry picked from commit 16e49fd)

* Fix doc - porting_guide_2.8 value example (#63493)

(cherry picked from commit e0f67b5)

* Fix warnings for ufw examples (#63505)

(cherry picked from commit e4eea05)
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Oct 26, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. files Files category module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants