Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unarchive: Add example to clear the usage of extra_opts #31873

Merged
merged 1 commit into from
Apr 3, 2018
Merged

unarchive: Add example to clear the usage of extra_opts #31873

merged 1 commit into from
Apr 3, 2018

Conversation

kassiansun
Copy link
Contributor

SUMMARY

Add an example to clear the usage of extra_opts

Close #26217, as I don't have original repository now.

Fixes #26173, seems that ansible changed its behavior of extra_opts, it's essential to make it clearer for users.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

files/unarchive

ANSIBLE VERSION
ansible 2.4.0
ADDITIONAL INFORMATION

None

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2017

cc @pileofrogs
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. m:unarchive This issue/PR relates to the unarchive module. labels Oct 18, 2017
@gundalow gundalow changed the title Add example to clear the usage of extra_opts unarchive: Add example to clear the usage of extra_opts Oct 18, 2017
@gundalow gundalow mentioned this pull request Oct 18, 2017
Closed
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2017
@aes
Copy link

aes commented Oct 23, 2017

Spot on. For style, I would've preferred

- --transform=s/^xxx/yyy/

because it makes the transform arg a cohesive unit list item, but this is a much better explanation.

@kassiansun
Copy link
Contributor Author

This pr tries to clear the usage of command line options with blank space. ansible will escape passed command line options, so you can't use --transform s/^xxx/yyy, it will be surrounded by a pair of ".

@aes
Copy link

aes commented Oct 24, 2017

Yes, exactly, but that's not what I wrote. Here, at least, tar takes --transform ... as two args, or --transform=... as one arg. My point is that the latter is preferable for style, but former for use as an example.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 1, 2017
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 1, 2018
@mkrizek
Copy link
Contributor

mkrizek commented Mar 16, 2018

cc @dharmabumstead

@Akasurde
Copy link
Member

Akasurde commented Apr 1, 2018

@gundalow @mkrizek @daxlab Are we waiting for something in this PR ?

@daxlab
Copy link

daxlab commented Apr 1, 2018

@Akasurde LGTM.

@mkrizek
Copy link
Contributor

mkrizek commented Apr 3, 2018

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 3, 2018
@ansibot ansibot merged commit 72657ce into ansible:devel Apr 3, 2018
@Akasurde
Copy link
Member

Akasurde commented Apr 3, 2018

@kassiansun Thanks for the contribution. @daxlab @gundalow @mkrizek Thanks for review.

ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@ryancurrah
Add example to clear the usage of extra_opts (ansible#31873)
fcfe0a7
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
Add example to clear the usage of extra_opts (ansible#31873)
e8e1e24
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@mkrizek mkrizek mkrizek approved these changes

@daxlab daxlab daxlab approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. m:unarchive This issue/PR relates to the unarchive module. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

after 2.2.0.0, unarchive no longer finds handler for .tar.gz if extra_opts is used
7 participants
@kassiansun @ansibot @aes @mkrizek @Akasurde @daxlab @gundalow