Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos_eapi: Added fix for bug # 51144 #63632

Merged
merged 5 commits into from Oct 23, 2019
Merged

eos_eapi: Added fix for bug # 51144 #63632

merged 5 commits into from Oct 23, 2019

Conversation

GomathiselviS
Copy link
Contributor

@GomathiselviS GomathiselviS commented Oct 17, 2019 •
edited by Qalthos

SUMMARY

Fixes #51144

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eos_eapi.py

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2019

cc @privateip @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2019

@GomathiselviS, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 17, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/eos/eos_eapi.py:266:0: trailing-whitespace: Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/eos/eos_eapi.py:266:1: W293: blank line contains whitespace

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 17, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 17, 2019

Build succeeded (third-party-check pipeline).

@Qalthos
Copy link
Contributor

Qalthos commented Oct 18, 2019

The linked issue mentions using the module with no config. Can we add a test with set_module_args(dict())?

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2019

cc @NilashishC @danielmellado @ganeshrn @justjais
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed needs_triage Needs a first human triage before being processed. labels Oct 18, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 18, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 18, 2019

Build succeeded (third-party-check pipeline).

@GomathiselviS
Copy link
Contributor Author

The linked issue mentions using the module with no config. Can we add a test with set_module_args(dict())?

@Qalthos I have added the test.

@justjais justjais merged commit 68de182 into ansible:devel Oct 23, 2019
@ansible ansible locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@privateip privateip Awaiting requested review from privateip

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eos_eapi does not turn on eapi by default
4 participants
@GomathiselviS @ansibot @Qalthos @justjais