ec2_instance test cleanup #63708
Merged
ec2_instance test cleanup #63708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tremble, just so you are aware we have a dedicated Working Group for aws. |
ansibot
added
affects_2.10
tremble
force-pushed
the
tests_ec2_instance
branch
from
23a91ca
to
3e241a8
Compare
ansibot
added
core_review
|
I believe the code's good at this point, so reviews would be appreciated. Over the course of the next couple of hours I'm going to try to trigger additional test runs in the Shippable environment by rebasing, cleaning up unused/duplicate files and tweaking the documentation a little bit. However, I believe I've tracked down the cause of the instability... |
tremble
force-pushed
the
tests_ec2_instance
branch
from
6f5043f
to
29940c3
Compare
ansibot
added
needs_revision
|
@tremble This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
ansibot
added
the
needs_rebase
tremble
force-pushed
the
tests_ec2_instance
branch
from
c15cf05
to
e227f65
Compare
ansibot
removed
the
needs_rebase
tremble
force-pushed
the
tests_ec2_instance
branch
from
e227f65
to
a053a64
Compare
ansibot
added
core_review
tremble
force-pushed
the
tests_ec2_instance
branch
from
38e05ca
to
2deeb33
Compare
|
@s-hertel I'll push more rebases through out the day, but I think the tests are now consistently passing. |
tremble
force-pushed
the
tests_ec2_instance
branch
from
2deeb33
to
00fc780
Compare
s-hertel
reviewed
Oct 21, 2019
test/integration/targets/ec2_instance_a/tasks/external_resource_attach.yml
Outdated
Show resolved
Hide resolved
ansibot
removed
the
needs_triage
tremble
force-pushed
the
tests_ec2_instance
branch
from
b8acac4
to
0733f38
Compare
|
The test |
ansibot
added
ci_verified
s-hertel
approved these changes
Oct 21, 2019
tremble
force-pushed
the
tests_ec2_instance
branch
from
0733f38
to
cd1f132
Compare
ansibot
added
core_review
|
Thanks @tremble! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Attempts to stabilise the ec2_instance tests (see also #58650)
CC: @s-hertel
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/amazon/ec2_instance.py
test/sanity/ignore.txt
ADDITIONAL INFORMATION
Found one 'interesting' quirk - 'wait' only waits for the completion of actions initiated by the specific call.
If you pass a filter or multiple instance_ids and they're already transitioning to the new state, then 'wait' will return straight away rather than waiting for the instances to reach the desired state. This is problematic when dealing with mass-removals where you need to wait for dependencies to be 'gone' before deleting them (eg waiting on instance termination before deleting ENIs/volumes)