Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8] sysctl: fix 'err' referenced before assignment #64139

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[2.8] sysctl: fix 'err' referenced before assignment #64139

merged 1 commit into from
Nov 12, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Oct 31, 2019 •
edited by mattclay
Loading

SUMMARY
  • sysctl: fix 'err' referenced before assignment
  • Add changelog

Fixes #63967

(cherry picked from commit 9069a68)

Backport of #58161

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/58158-sysctl-fix-referenced-before-assignment.yaml
lib/ansible/modules/system/sysctl.py

@mkrizek @Akasurde
sysctl: fix 'err' referenced before assignment
c238ef4 
* sysctl: fix 'err' referenced before assignment
* Add changelog

Fixes ansible#63967

(cherry picked from commit 9069a68)
@Akasurde Akasurde mentioned this pull request Oct 31, 2019
Closed
@Akasurde Akasurde changed the base branch from devel to stable-2.8 October 31, 2019 07:01
@ansibot
Copy link
Contributor

ansibot commented Oct 31, 2019

cc @davixx
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 31, 2019
@Akasurde Akasurde closed this Oct 31, 2019
@Akasurde Akasurde reopened this Oct 31, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 31, 2019
@Akasurde Akasurde requested a review from mkrizek October 31, 2019 09:18
@Akasurde Akasurde removed needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 31, 2019
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Oct 31, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 31, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@Akasurde Akasurde closed this Nov 5, 2019
@Akasurde Akasurde reopened this Nov 5, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Nov 5, 2019

Build succeeded (third-party-check pipeline).

@mattclay mattclay added the backport_verified This PR has been verified as a backport of a merged devel PR. label Nov 6, 2019
@Akasurde Akasurde changed the title sysctl: fix 'err' referenced before assignment [2.8] sysctl: fix 'err' referenced before assignment Nov 8, 2019
@nitzmahone nitzmahone merged commit 8b5cd5b into ansible:stable-2.8 Nov 12, 2019
@Akasurde Akasurde deleted the backport/2.8/58161 branch November 12, 2019 02:15
@ansible ansible locked and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek Awaiting requested review from mkrizek

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport_verified This PR has been verified as a backport of a merged devel PR. backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Akasurde @ansibot @mattclay @nitzmahone @mkrizek