Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add podman_container_info module #64361

Merged
merged 2 commits into from Dec 6, 2019
Merged

Add podman_container_info module #64361

merged 2 commits into from Dec 6, 2019

Conversation

sshnaidm
Copy link
Contributor

@sshnaidm sshnaidm commented Nov 3, 2019

SUMMARY

Introduce a new module podman_container_info
It collects information of podman containers on the host using podman container inspect command.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

podman_container_info

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 3, 2019
@ansibot
Copy link
Contributor

ansibot commented Nov 3, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/podman/podman_container_info.py:318:9: return-syntax-error: RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/podman/podman_container_info.py:318:9: error: RETURN: syntax error: expected ',' or ']', but got '}'

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 3, 2019
@ansibot
Copy link
Contributor

ansibot commented Nov 3, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/podman/podman_container_info.py:63:9: return-syntax-error: RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/podman/podman_container_info.py:63:9: error: RETURN: syntax error: could not find expected ':'

click here for bot help

@sshnaidm sshnaidm force-pushed the podman_container_info branch 4 times, most recently from c5c767e to 0cf9d19 Compare November 3, 2019 19:09
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 3, 2019
@sshnaidm
Copy link
Contributor Author

sshnaidm commented Nov 4, 2019

@felixfontein @samdoran @TomasTomecek please take a look

@sshnaidm
Copy link
Contributor Author

@felixfontein take a look please, now shouldn't fail if some container doesn't exist.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 15, 2019
@sshnaidm sshnaidm force-pushed the podman_container_info branch 3 times, most recently from 6a5c6c5 to e7effde Compare November 16, 2019 01:08
@sshnaidm sshnaidm force-pushed the podman_container_info branch 2 times, most recently from a7fc823 to 9f6d697 Compare November 16, 2019 13:17
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 16, 2019
felixfontein
felixfontein approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 16, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core labels Nov 16, 2019
felixfontein
felixfontein approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 17, 2019
@felixfontein
Copy link
Contributor

@samdoran do you want to take a look as well?

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Dec 2, 2019
@ansibot
Copy link
Contributor

ansibot commented Dec 5, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/podman/podman_container_info.py:0:0: doc-missing-type: Argument 'argument_spec' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/cloud/podman/podman_container_info.py:0:0: nonexistent-parameter-documented: Argument 'name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/podman/podman_container_info.py:0:0: undocumented-parameter: Argument 'argument_spec' is listed in the argument_spec, but not documented in the module documentation

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/podman/podman_container_info.py:390:9: E122: continuation line missing indentation or outdented
lib/ansible/modules/cloud/podman/podman_container_info.py:393:9: E122: continuation line missing indentation or outdented

click here for bot help

@sshnaidm @felixfontein
Update lib/ansible/modules/cloud/podman/podman_container_info.py
8ce6a29 
Co-Authored-By: Felix Fontein <felix@fontein.de>
@samdoran samdoran merged commit e444e68 into ansible:devel Dec 6, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 6, 2019
anshulbehl pushed a commit to anshulbehl/ansible that referenced this pull request Dec 10, 2019
@sshnaidm @felixfontein @anshulbehl
Add podman_container_info module (ansible#64361)
610e9f0 
Co-Authored-By: Felix Fontein <felix@fontein.de>
@ansible ansible locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sshnaidm @ansibot @felixfontein @samdoran @sivel