Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] Fix nxos_file_copy option value path validation #65846

Merged
merged 2 commits into from
Jan 10, 2020
Merged

[2.9] Fix nxos_file_copy option value path validation #65846

merged 2 commits into from
Jan 10, 2020

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Dec 15, 2019 •
edited by mattclay
Loading

SUMMARY

  • Fix nxos_file_copy option value path validation

  • Modify local_file, local_file_directory and
    remote_file option type from str to path
    so that the option value is validated in Ansible
    for a legitimate path value

  • Fix review comments

(cherry picked from commit 88008ba)
Backport of #65423

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_file_copy

ADDITIONAL INFORMATION

@ganeshrn
Fix nxos_file_copy option value path validation (ansible#65423)
254d803 
* Fix nxos_file_copy option value path validation

*  Modify `local_file`, `local_file_directory` and
   `remote_file` option type from `str` to `path`
   so that the option value is validated in Ansible
   for a legitimate path value

* Fix review comments

(cherry picked from commit 88008ba)
@ansibot
Copy link
Contributor

ansibot commented Dec 15, 2019

cc @GGabriele @NilashishC @Qalthos @chrisvanheuveln @danielmellado @jedelman8 @justjais @mikewiebe @rahushen @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 15, 2019
@Akasurde Akasurde changed the title Fix nxos_file_copy option value path validation (#65423) [2.9] Fix nxos_file_copy option value path validation Dec 15, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 15, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 25, 2019
@mattclay mattclay merged commit 1257448 into ansible:stable-2.9 Jan 10, 2020
@ansible ansible locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganeshrn @ansibot @Akasurde @mattclay