Redhat_subscription fails when quantity isn't given on a physical server.

[AdamMorris23]

SUMMARY

Using the redhat_subscription module with pool_ids and no quantities on a physical server causes the quantity to be forced to 1. This results in a warning on stdout from redhat_subscription and a return code of 1. This causes the action to be marked as FAILED although subscription_manager does the right thing.

ISSUE TYPE

• Bug Report

COMPONENT NAME

redhat_subscription

ANSIBLE VERSION

ansible 2.8.6
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/morrisa/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Jun 11 2019, 14:33:56) [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)]

CONFIGURATION

DEFAULT_ROLES_PATH(/etc/ansible/ansible.cfg) = [u'/etc/ansible/roles', u'/usr/share/ansible/roles']

OS / ENVIRONMENT

Tested with Ansible 2.9, not tested with the development version yet but the issue is still there in the code. Target OS Version is RedHat Enterprise Linux 7.6 on a two socket physical server.

STEPS TO REPRODUCE

Using a physical server with two sockets execute the equivalent of the yaml below.

- name: Same as above but subscribe to a specific pool by ID.
  redhat_subscription:
    state: present
    username: joe_user
    password: somepass
    pool_ids: 0123456789abcdef0123456789abcdef

EXPECTED RESULTS

I expect the system to be subscribed to a given pool.

ACTUAL RESULTS

This play fails with a warning on stdout that Quantity needs to be a multiple of 2 and a return code of 1. Subscription-manager does the right thing but the return code causes Ansible to choke.

In the main code if pool_ids is provided without a quantity then it is set to 1. This is not valid for a two socket physical server.

[ansibot]

Files identified in the description:

• lib/ansible/modules/packaging/os/redhat_subscription.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @alikins @barnabycourt @kahowell
click here for bot help

[jirihnidek]

When quantity is not specified, then default value 1 is used:

ansible/lib/ansible/modules/packaging/os/redhat_subscription.py

Line 842 in 1152774

pool_id, quantity = value, 1

This works in most cases, but not in case described in this issue. When special type of product is used, then it is required to attach at least quantity e.g. 2 on physical server. When no quantity is specified, then subscription-manager is able to attach correct minimal quantity as it is demonstrated in following example:

[root@localhost ~]# subscription-manager attach --pool ff8080816fd8736f016fd87669c702b5 --quantity=1
Subscription "Awesome OS Instance Based (Standard Support)" must be attached using a quantity evenly divisible by 2
[root@localhost ~]# subscription-manager attach --pool ff8080816fd8736f016fd87669c702b5
Successfully attached a subscription for: Awesome OS Instance Based (Standard Support)

When quantity is not specified, then I propose to set quantity to None and not set --quantity option here:

ansible/lib/ansible/modules/packaging/os/redhat_subscription.py

Line 518 in 1152774

args = [SUBMAN_CMD, 'attach', '--pool', pool_id, '--quantity', quantity]

@cnsnyder Thoughts?