Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure_rm_rg_info: fix KeyError: 'ansible_facts' #66729

Merged
merged 2 commits into from Feb 16, 2020
Merged

azure_rm_rg_info: fix KeyError: 'ansible_facts' #66729

merged 2 commits into from Feb 16, 2020

Conversation

derkoe
Copy link
Contributor

@derkoe derkoe commented Jan 23, 2020

Fix facts for using old azure_rm_resourcegroup_facts,

SUMMARY

Fixes #66727

Adds the ansible_facts as a sub map to fix the KeyError

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure / azure_rm_resourcegroup_info

ADDITIONAL INFORMATION

None

@derkoe
azure_rm_rg_info: fix KeyError: 'ansible_facts'
e4a9468 
Fix facts for using old azure_rm_resourcegroup_facts, closes #66727
@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2020

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_resourcegroup_info.py:187:15: E121: continuation line under-indented for hanging indent

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2020

cc @gavinfish @haiyuazhang @haroldwongms @nitzmahone @yungezz @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2020

@derkoe, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 azure bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jan 23, 2020
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 23, 2020
@ansibleazurebot ansibleazurebot mentioned this pull request Jan 24, 2020
Closed
@derkoe
Copy link
Contributor Author

derkoe commented Jan 31, 2020

ready_for_review

@Fred-sun
Copy link
Contributor

Fred-sun commented Feb 3, 2020

@gavinfish @haiyuazhang

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 3, 2020
felixfontein
felixfontein reviewed Feb 16, 2020
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You need a changelog fragment, though.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 16, 2020
gavinfish
gavinfish approved these changes Feb 16, 2020
View reviewed changes
Copy link

@gavinfish gavinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@felixfontein felixfontein merged commit 569f0cf into ansible:devel Feb 16, 2020
@felixfontein
Copy link
Contributor

Thanks for fixing and reviewing this!

Who wants to create a backport for stable-2.9?

@Fred-sun
Copy link
Contributor

@haiyuazhang Can you submit backport PR to back up this change to version 2.9? Thank you very much

@derkoe derkoe mentioned this pull request Feb 17, 2020
Merged
@derkoe
Copy link
Contributor Author

derkoe commented Feb 17, 2020

here you go #67479

mattclay pushed a commit that referenced this pull request Mar 3, 2020
@derkoe
azure_rm_rg_info: fix KeyError: 'ansible_facts' (#66729) (#67479)
1b65ecc 
* azure_rm_rg_info: fix KeyError: 'ansible_facts' (#66729)

* azure_rm_rg_info: fix KeyError: 'ansible_facts'

Fix facts for using old azure_rm_resourcegroup_facts, closes #66727

* fix intendation

(cherry picked from commit 569f0cf)

* azure_rm_rg_info: add changelog fragment
@ansible ansible locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein left review comments

@gavinfish gavinfish gavinfish approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. has_issue module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_rm_resourcegroup_facts does not work with ansible 2.9.x
5 participants
@derkoe @ansibot @Fred-sun @felixfontein @gavinfish