Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collection naming guidelines to galaxy documentation #69171

Closed
IPvSean opened this issue Apr 25, 2020 · 9 comments
Closed

Update collection naming guidelines to galaxy documentation #69171

IPvSean opened this issue Apr 25, 2020 · 9 comments
Labels
affects_2.10 This issue/PR affects Ansible v2.10 docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@IPvSean
Copy link
Contributor

IPvSean commented Apr 25, 2020

SUMMARY

it is not documented that - dashes will not work in the documentation (here https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#developing-collections)

I get an error like this->

ERROR! Error when publishing collection to release_galaxy (https://galaxy.ansible.com/api/) (HTTP Code: 400, Message: Invalid version string: 'demos-1.0.0' Code: invalid)

However underscores work! It is documented in the galaxy.yml init file! So we should copy that same logic into the documentation

In the galaxy.yml file I see this->

# The namespace of the collection. This can be a company/brand/organization or product namespace under which all
# content lives. May only contain alphanumeric characters and underscores. Additionally namespaces cannot start with
# underscores or numbers and cannot contain consecutive underscores

can we re-use that?

ISSUE TYPE
  • Documentation Report
COMPONENT NAME

docs

ANSIBLE VERSION
2.10
CONFIGURATION

OS / ENVIRONMENT
ADDITIONAL INFORMATION
@ansibot
Copy link
Contributor

ansibot commented Apr 25, 2020

Files identified in the description:
None

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 25, 2020

@IPvSean: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 25, 2020
@jborean93
Copy link
Contributor

Just an FYI we do not have the ability to modify the error message from ansible-galaxy publish as that’s what is returned from the Galaxy instance. If you wanted to make that a bit more obvious you need to raise the issue there.

@IPvSean
Copy link
Contributor Author

IPvSean commented Apr 25, 2020 via email

@jborean93
Copy link
Contributor

jborean93 commented Apr 25, 2020

If you want to update the docs at https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#developing-collections then we can do that. As you’ve seen we already have some info on this on the templated galaxy.yml file.

If you want the error message from ansible-galaxy publish to have this information then we can’t. We just output the error code and message from what the API returns. Because that’s where all the validation occurs and we don’t want to duplicate efforts especially since the endpoint should be the source of truth for the validation.

@jimi-c jimi-c added docs This issue/PR relates to or includes documentation. and removed needs_triage Needs a first human triage before being processed. feature This issue/PR relates to a feature request. labels May 5, 2020
@sivel sivel changed the title add galaxy documentation to master ansible.cfg Update collection naming guidelines to galaxy documentation May 5, 2020
@sivel
Copy link
Member

sivel commented May 5, 2020

bot_status

@ansibot
Copy link
Contributor

ansibot commented May 5, 2020

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 5, 2020

Components

docs/docsite/README.md
support: core
maintainers: acozine

Metadata

waiting_on: maintainer
needs_info: False

click here for bot help

@ansibot ansibot removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels May 5, 2020
@samccann
Copy link
Contributor

We added a note in the docs to point to the namespace etc limitations documentation - https://docs.ansible.com/ansible/2.10/dev_guide/developing_collections.html#creating-a-collection-skeleton

@ansible ansible locked and limited conversation to collaborators Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

No branches or pull requests

6 participants