Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] ansible-test: make pylint deprecation plugin not choke on tagged versions #69851

Merged
merged 2 commits into from Jun 3, 2020
Merged

[2.9] ansible-test: make pylint deprecation plugin not choke on tagged versions #69851

merged 2 commits into from Jun 3, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Ignores TypeErrors raised when LooseVersions starting with str components are compared to ones starting with int components. This happens if a tagged collection version like community.general:1.0.0 is compared to the Ansible version 2.9.

CC @nitzmahone @mattclay

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-test

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jun 3, 2020
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jun 3, 2020
@nitzmahone nitzmahone merged commit 55eb276 into ansible:stable-2.9 Jun 3, 2020
@felixfontein felixfontein deleted the 2.9-deprecation-plugin branch June 3, 2020 19:36
@felixfontein
Copy link
Contributor Author

@mattclay @nitzmahone thanks for reviewing and merging!

@ansible ansible locked and limited conversation to collaborators Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @mattclay @nitzmahone @ansibot