Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] ansible-test: make pylint deprecation plugin not choke on tagged versions #69851

Merged
merged 2 commits into from Jun 3, 2020
Merged

[2.9] ansible-test: make pylint deprecation plugin not choke on tagged versions #69851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddda086
ansible-test pylint: do not choke on module.deprecate() / display.dep…
felixfontein Jun 3, 2020
ee5efe6
Add changelog fragment.
felixfontein Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/69851-ansible-test-pylint-versions.yml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- "ansible-test pylint sanity test - do not crash when ``version`` specified to ``AnsibleModule.deprecate()`` or ``Display.deprecated()`` contains string components, f.ex. tagged version numbers for Ansible 2.10."
5 changes: 5 additions & 0 deletions test/lib/ansible_test/_data/sanity/pylint/plugins/deprecated.py
View file
Open in desktop
Expand Up @@ -87,6 +87,11 @@ def visit_call(self, node):
self.add_message('ansible-deprecated-version', node=node, args=(version,))
except ValueError:
self.add_message('ansible-invalid-deprecated-version', node=node, args=(version,))
except TypeError:
# This happens if version starts with string components, and LooseVersion
# comparison tries to compare int with str. This can happen for tagged
# versions from Ansible 2.10.
pass
except AttributeError:
# Not the type of node we are interested in
pass
Expand Down