kubectl connection plugin broken in 2.9.14

[kdelee]

SUMMARY

3728530#r43109609 this commit introduced a programming error, a function is called expecting 2 return values, but the function only returns 1 return value.

ISSUE TYPE

• Bug Report

COMPONENT NAME

kubectl connection plugin

ANSIBLE VERSION

ansible 2.9.14.post0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Mar 20 2020, 17:08:22) [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)]

CONFIGURATION

no changes

OS / ENVIRONMENT

RHEL 7.8

STEPS TO REPRODUCE

similar to https://github.com/ansible-collections/community.kubernetes/issues/200

test.yml

---

- name: Prepare data, dispatch job in isolated environment.
  hosts: all
  gather_facts: false

  tasks:
    - command: "echo hello"

ansible-playbook -c kubectl -i 'name-of-pod-on-kubernetes' test.yml -e ansible_kubectl_config=${KUBE_CONFIG_PATH} -vvv

EXPECTED RESULTS

Works

ACTUAL RESULTS

TASK [command] *******************************************************************************************************
task path: /home/elijah/sfw/ansible/awx/foo.yml:8
<nginx-app-proxy-85cc95c5fc-8cqdr> ESTABLISH kubectl CONNECTION
The full traceback is:
Traceback (most recent call last):
  File "/home/elijah/venv/python3towerqa/lib64/python3.8/site-packages/ansible/executor/task_executor.py", line 147, in run
    res = self._execute()
  File "/home/elijah/venv/python3towerqa/lib64/python3.8/site-packages/ansible/executor/task_executor.py", line 665, in _execute
    result = self._handler.run(task_vars=variables)
  File "/home/elijah/venv/python3towerqa/lib64/python3.8/site-packages/ansible/plugins/action/command.py", line 24, in run
    results = merge_hash(results, self._execute_module(task_vars=task_vars, wrap_async=wrap_async))
  File "/home/elijah/venv/python3towerqa/lib64/python3.8/site-packages/ansible/plugins/action/__init__.py", line 790, in _execute_module
    self._make_tmp_path()
  File "/home/elijah/venv/python3towerqa/lib64/python3.8/site-packages/ansible/plugins/action/__init__.py", line 353, in _make_tmp_path
    tmpdir = self._remote_expand_user(self.get_shell_option('remote_tmp', default='~/.ansible/tmp'), sudoable=False)
  File "/home/elijah/venv/python3towerqa/lib64/python3.8/site-packages/ansible/plugins/action/__init__.py", line 674, in _remote_expand_user
    data = self._low_level_execute_command(cmd, sudoable=False)
  File "/home/elijah/venv/python3towerqa/lib64/python3.8/site-packages/ansible/plugins/action/__init__.py", line 1085, in _low_level_execute_command
    rc, stdout, stderr = self._connection.exec_command(cmd, in_data=in_data, sudoable=sudoable)
  File "/home/elijah/venv/python3towerqa/lib64/python3.8/site-packages/ansible/plugins/connection/kubectl.py", line 286, in exec_command
    local_cmd, censored_local_cmd = self._build_exec_cmd([self._play_context.executable, '-c', cmd])
ValueError: too many values to unpack (expected 2)
fatal: [nginx-app-proxy-85cc95c5fc-8cqdr]: FAILED! => {
    "msg": "Unexpected failure during module execution.",
    "stdout": ""
}

@mattclay this is a tower blocker because we use the kubectl connection plugin for container groups

[ansibot]

Files identified in the description:

• lib/ansible/plugins/connection

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[kdelee]

connect #72130
#72131

[Akasurde]

For 2.8 - #72131
For 2.9 - #72130