Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant remote_user for local setting #72508

Merged
merged 2 commits into from Dec 7, 2020
Merged

remove redundant remote_user for local setting #72508

merged 2 commits into from Dec 7, 2020

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Nov 5, 2020

local action plugin already does and this also should fix
fork/thread issue by removing use of pwd library

fixes #59642

(cherry picked from commit 488b9d6)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

play_context

@bcoca
remove redundant remote_user for local setting
991369d 
  local action plugin already does and this also should fix
  fork/thread issue by removing use of pwd library

  fixes ansible#59642

(cherry picked from commit 488b9d6)
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 5, 2020
@pabelanger
Copy link
Contributor

recheck

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Nov 5, 2020
@pabelanger
Copy link
Contributor

recheck

@felixfontein
Copy link
Contributor

This commit in devel breaks copy with delegate_to: localhost for me (#72412 (comment)).

@bcoca
Copy link
Member Author

bcoca commented Nov 9, 2020

fix in #72543, will add comimt to this PR

@bcoca
ensure local exposes correct user (ansible#72543)
207b9f5 
* ensure local exposes correct user

  avoid corner case in which delegation relied on
  playcontext fallback which was removed

  fixes ansible#72541

(cherry picked from commit aa4d53c)
@bcoca
Copy link
Member Author

bcoca commented Nov 9, 2020

added fix to this pr

felixfontein
felixfontein approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Nov 9, 2020
@samdoran
Copy link
Contributor

recheck

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 19, 2020
@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Dec 5, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 5, 2020
@relrod
Copy link
Member

relrod commented Dec 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 7, 2020
@relrod relrod merged commit ce52e67 into ansible:stable-2.9 Dec 7, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 8, 2020
@ansible ansible locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bcoca @pabelanger @felixfontein @samdoran @relrod @sivel @ansibot