Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant remote_user for local setting #72412

Merged
merged 1 commit into from Nov 5, 2020

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Oct 30, 2020

local action plugin already does and this also should fix
fork/thread issue by removing use of pwd library

fixes #59642

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

play_context

  local action plugin already does and this also should fix
  fork/thread issue by removing use of pwd library

  fixes ansible#59642
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 30, 2020
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Nov 5, 2020
@mattclay mattclay merged commit 488b9d6 into ansible:devel Nov 5, 2020
@felixfontein
Copy link
Contributor

This PR breaks the following playbook (t.yml) for me:

- hosts: remote_server
  tasks:
  - copy:
      src: t.yml
      dest: /tmp/t.yml
    delegate_to: localhost

It does not break when hosts: localhost.

@felixfontein
Copy link
Contributor

fatal: [remote-server]: UNREACHABLE! => {"changed": false, "msg": "Failed to create temporary directory.In some cases, you may have been able to authenticate and did not have permissions on the target directory. Consider changing the remote tmp path in ansible.cfg to a path rooted in \"/tmp\", for more error information use -vvv. Failed command was: ( umask 77 && mkdir -p \"` echo /root/.ansible/tmp `\"&& mkdir \"` echo /root/.ansible/tmp/ansible-tmp-1604856819.0247443-194052-180695334418942 `\" && echo ansible-tmp-1604856819.0247443-194052-180695334418942=\"` echo /root/.ansible/tmp/ansible-tmp-1604856819.0247443-194052-180695334418942 `\" ), exited with result 1", "unreachable": true}

@bcoca
Copy link
Member Author

bcoca commented Nov 9, 2020

I cannot reproduce with that play.

@felixfontein
Copy link
Contributor

Looks like this only happens (for me) if the remote user is root, while I run the playbook as a regular user.

@bcoca bcoca deleted the remove_unused_fix_fork branch November 9, 2020 16:20
@ansible ansible locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsafe use of fork() after join()-ing threads causes ansible to hang under certain conditions.
4 participants