Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to upgrade collections #73336

Merged
merged 8 commits into from Feb 3, 2021
Merged

add option to upgrade collections #73336

merged 8 commits into from Feb 3, 2021

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Jan 23, 2021 •
edited

SUMMARY

Add an --upgrade/-U flag to ansible-galaxy collection install.

Support installing a collection with new version requirements instead of necessitating --force/--force-with-deps

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-galaxy collection install

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.11 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 23, 2021
@s-hertel s-hertel force-pushed the ansible-galaxy_collection_upgrade branch 2 times, most recently from d130756 to 079955f Compare January 23, 2021 03:32
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jan 26, 2021
@s-hertel s-hertel force-pushed the ansible-galaxy_collection_upgrade branch from 079955f to 684fcaf Compare January 27, 2021 22:13
@ansibot ansibot added the docs This issue/PR relates to or includes documentation. label Jan 27, 2021
@s-hertel s-hertel force-pushed the ansible-galaxy_collection_upgrade branch from 684fcaf to 4d12911 Compare January 27, 2021 22:21
@s-hertel s-hertel mentioned this pull request Jan 29, 2021
Closed
@s-hertel s-hertel changed the title [WIP] add option to upgrade collections add option to upgrade collections Jan 29, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jan 29, 2021
@s-hertel s-hertel force-pushed the ansible-galaxy_collection_upgrade branch from a98f169 to c4b7dd3 Compare January 30, 2021 21:53
@s-hertel @webknjaz
Add a flag to ansible-galaxy to update collections
08847b4 
Filter out preinstalled collections that don't match the new version requirements

Add an example to the documentation

changelog

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@s-hertel s-hertel force-pushed the ansible-galaxy_collection_upgrade branch from c4b7dd3 to 08847b4 Compare January 30, 2021 23:06
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 1, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 1, 2021
webknjaz
webknjaz reviewed Feb 2, 2021
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-hertel is -U compatible with -r? do we want to test this?

changelogs/fragments/73336-ansible-galaxy_collection_install_upgrade.yaml Outdated Show resolved Hide resolved
lib/ansible/cli/galaxy.py Outdated Show resolved Hide resolved
lib/ansible/cli/galaxy.py Outdated Show resolved Hide resolved
lib/ansible/galaxy/collection/__init__.py Outdated Show resolved Hide resolved
lib/ansible/galaxy/collection/__init__.py Outdated Show resolved Hide resolved
test/integration/targets/ansible-galaxy-collection/tasks/upgrade.yml Show resolved Hide resolved
test/integration/targets/ansible-galaxy-collection/tasks/upgrade.yml Show resolved Hide resolved
jborean93
jborean93 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, very in depth tests as well which is fantastic.

test/integration/targets/ansible-galaxy-collection/tasks/upgrade.yml Outdated Show resolved Hide resolved
test/integration/targets/ansible-galaxy-collection/tasks/upgrade.yml Outdated Show resolved Hide resolved
test/integration/targets/ansible-galaxy-collection/tasks/upgrade.yml Show resolved Hide resolved
@s-hertel s-hertel force-pushed the ansible-galaxy_collection_upgrade branch from 4568e74 to ded81d9 Compare February 2, 2021 21:59
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 2, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 2, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 3, 2021
@s-hertel s-hertel mentioned this pull request Feb 3, 2021
Closed
@jborean93 jborean93 merged commit 9759e0c into ansible:devel Feb 3, 2021
This was referenced Feb 3, 2021
Closed
Closed
@ansible ansible locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s-hertel @webknjaz @jborean93 @ansibot