Invalid error message on GnuPG key import error in the apt_key module

[maximmasiutin]

Summary

When importing a key by the apt_key module, in case of error, the error message was incorrect, because the logic to distinguish between the file name and the explicit data was inversed.

The error message was:

Unable to extract key from '-'

While it should have been:

Unable to extract key from 'inline data'

The relevant code is in the following line from: /lib/ansible/modules/apt_key.py

module.fail_json(msg="Unable to extract key from '%s'" % ('inline data' if data is None else filename), stdout=out, stderr=err)
(it should have been if data is None)

Issue Type

Bug Report

Component Name

ansible.builtin.apt_key module

Ansible Version

2.12.0.dev0 (latest revision from GitHub)
2.11.0rc2 (from pip install ansible)

Configuration

config not changed

OS / Environment

Ubuntu 18

Steps to Reproduce

To reproduce this error, create the following files:

The Vagrantfile file:

Vagrant.configure("2") do |config|
  config.vm.base_mac = nil
  config.vm.synced_folder ".", "/vagrant", disabled: false

  config.vm.define "test-host" do |n|
    n.vm.box = "ubuntu/bionic64"
    n.vm.hostname = "test-host"
    n.vm.provision :ansible do |ansible|
      ansible.limit = "all"
      ansible.playbook = "test.yaml"
    end
  end
end

The test.yaml file:

- name: Test Playbook
  hosts: test-host
  become: yes
  tasks:
    - name: Add binary key
      apt_key: url=https://packages.cloud.google.com/apt/doc/apt-key.gpg

and run vagrant up

Expected Results

Unable to extract key from 'inline data'

Actual Results

Unable to extract key from '-'

Relevant file:
lib/ansible/modules/apt_key.py

@jvantuyl - please review
@Akasurde - please review

Fixed by #74476

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibot]

Files identified in the description:

• lib/ansible/modules/apt_key.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help