Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro_inventory.rst #76340

Merged
merged 2 commits into from Dec 14, 2021
Merged

Update intro_inventory.rst #76340

merged 2 commits into from Dec 14, 2021

Conversation

jmcgill298
Copy link
Contributor

I believe the first statement is clear enough, and that the second statement only creates confusion of where additional group|host_vars directories should be placed. As I read the second statement, I would expect the group|host_vars directories to be placed where the ansible-playbook command is issued. In practice, I have found that this is incorrect, and that the group|host_vars directories need to be adjance to the playbook that is being executed.

For example, executing ansible-playbook playbooks/pb.yml should have the group|host_vars directories inside the playbooks directories. Per the second statement, I would actually expect group|host_vars directories to be placed in the directory that the command is executed from.

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

I believe the first statement is clear enough, and that the second statement only creates confusion of where additional `group|host_vars` directories should be placed. As I read the second statement, I would expect the `group|host_vars` directories to be placed where the `ansible-playbook` command is issued. In practice, I have found that this is incorrect, and that the `group|host_vars` directories need to be adjance to the playbook that is being executed.

For example, executing `ansible-playbook playbooks/pb.yml` should have the `group|host_vars` directories inside the `playbooks` directories. Per the second statement, I would actually expect `group|host_vars` directories to be placed in the directory that the command is executed from.
@ansibot ansibot added affects_2.13 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docs_only All changes are to files within the docs/docsite/ directory needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 22, 2021
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Nov 30, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 30, 2021
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Nov 30, 2021
@samdoran
Copy link
Contributor

samdoran commented Dec 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 1, 2021
@samccann samccann merged commit ee77756 into ansible:devel Dec 14, 2021
@samccann
Copy link
Contributor

Thanks @jmcgill298 for the Ansible docs fix!

@jmcgill298 jmcgill298 deleted the patch-1 branch December 14, 2021 21:43
bcoca pushed a commit to bcoca/ansible that referenced this pull request Dec 15, 2021
@ansible ansible locked and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.13 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants