-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intro_inventory.rst #76340
Merged
Merged
Update intro_inventory.rst #76340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the first statement is clear enough, and that the second statement only creates confusion of where additional `group|host_vars` directories should be placed. As I read the second statement, I would expect the `group|host_vars` directories to be placed where the `ansible-playbook` command is issued. In practice, I have found that this is incorrect, and that the `group|host_vars` directories need to be adjance to the playbook that is being executed. For example, executing `ansible-playbook playbooks/pb.yml` should have the `group|host_vars` directories inside the `playbooks` directories. Per the second statement, I would actually expect `group|host_vars` directories to be placed in the directory that the command is executed from.
ansibot
added
affects_2.13
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
docs
This issue/PR relates to or includes documentation.
docs_only
All changes are to files within the docs/docsite/ directory
needs_triage
Needs a first human triage before being processed.
small_patch
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Nov 22, 2021
mkrizek
removed
the
needs_triage
Needs a first human triage before being processed.
label
Nov 30, 2021
bcoca
requested changes
Nov 30, 2021
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Nov 30, 2021
jmcgill298
commented
Nov 30, 2021
ansibot
added
the
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI.
label
Nov 30, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Dec 1, 2021
samccann
approved these changes
Dec 14, 2021
Thanks @jmcgill298 for the Ansible docs fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.13
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
docs_only
All changes are to files within the docs/docsite/ directory
docs
This issue/PR relates to or includes documentation.
small_patch
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the first statement is clear enough, and that the second statement only creates confusion of where additional
group|host_vars
directories should be placed. As I read the second statement, I would expect thegroup|host_vars
directories to be placed where theansible-playbook
command is issued. In practice, I have found that this is incorrect, and that thegroup|host_vars
directories need to be adjance to the playbook that is being executed.For example, executing
ansible-playbook playbooks/pb.yml
should have thegroup|host_vars
directories inside theplaybooks
directories. Per the second statement, I would actually expectgroup|host_vars
directories to be placed in the directory that the command is executed from.SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION