Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git integration test uses excessive network bandwidth #81327

Closed
1 task done
nitzmahone opened this issue Jul 21, 2023 · 1 comment · Fixed by #81600
Closed
1 task done

git integration test uses excessive network bandwidth #81327

nitzmahone opened this issue Jul 21, 2023 · 1 comment · Fixed by #81600
Assignees
@Akasurde
Labels
bug This issue/PR relates to a bug. has_pr This issue has an associated PR. module This issue/PR relates to a module.

Comments

@nitzmahone
Copy link
Member

Summary

The git integration test clones the ansible-examples repo (which has grown to > 50MB) numerous times from its Github source, and none of the tests appear to be getting additional benefit from the repeated internet access. This test should be rewritten in one or two steps to:

  1. clone the repo once from Github to a local tempdir, then all subsequent clone/fetch/checkout/etc tests should reference the local copy in the tempdir

  2. be entirely rewritten to use a much more compact integrated repo (thus requiring minimal-to-no internet access at all for the test)

Issue Type

Bug Report

Component Name

git integration test

Ansible Version

$ ansible --version

2.16 devel

Configuration

# if using a version older than ansible-core 2.12 you should omit the '-t all'
$ ansible-config dump --only-changed -t all

OS / Environment

NA

Steps to Reproduce

NA

Expected Results

Low bandwidth usage, fast tests

Actual Results

High bandwidth usage, resulting in slow/flaky tests

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. labels Jul 21, 2023
@ansibot
Copy link
Contributor

ansibot commented Jul 21, 2023

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the component bot command.

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jul 25, 2023
Akasurde pushed a commit to Akasurde/ansible that referenced this issue Aug 30, 2023
test: remove ansible-examples.git repo
97c281c 
* To speed up git tests remove reference to ansible-examples.git

Fixes: ansible#81327

Signed-off-by: Ansible Test Runner <noreply@example.com>
@Akasurde Akasurde mentioned this issue Aug 30, 2023
Merged
@ansibot ansibot added the has_pr This issue has an associated PR. label Aug 30, 2023
@Akasurde Akasurde self-assigned this Aug 30, 2023
@ansible ansible deleted a comment from rakeshkhopade12 Aug 31, 2023
s-hertel pushed a commit that referenced this issue Apr 17, 2024
@Akasurde @webknjaz
test: remove ansible-examples.git repo (#81600)
8c3c694 
* test: remove ansible-examples.git repo

* To speed up git tests remove reference to ansible-examples.git

Fixes: #81327

* Make CI green

Signed-off-by: Ansible Test Runner <noreply@example.com>
Co-authored-by: Ansible Test Runner <noreply@example.com>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@ansible ansible locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Akasurde Akasurde

Labels
bug This issue/PR relates to a bug. has_pr This issue has an associated PR. module This issue/PR relates to a module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: remove ansible-examples.git repo Akasurde/ansible
4 participants
@Akasurde @mkrizek @ansibot @nitzmahone