Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old_style_cache_plugins integration tests should not use redis #81328

Open
1 task done
nitzmahone opened this issue Jul 21, 2023 · 3 comments
Open
1 task done

old_style_cache_plugins integration tests should not use redis #81328

nitzmahone opened this issue Jul 21, 2023 · 3 comments
Assignees
Labels
bug This issue/PR relates to a bug.

Comments

@nitzmahone
Copy link
Member

Summary

The old_style_cache_plugins integration tests currently always build redis from source and test against a real plugin, which is very slow and flaky. We should be able to achieve equal or superior coverage and vastly increase the speed of the tests by writing a surrogate cache plugin that's backed by disk, Python data structures, or some other mechanism much lighter-weight than redis.

Issue Type

Bug Report

Component Name

old_style_cache_plugins integration tests

Ansible Version

$ ansible --version

2.16 devel

Configuration

# if using a version older than ansible-core 2.12 you should omit the '-t all'
$ ansible-config dump --only-changed -t all
NA

OS / Environment

NA

Steps to Reproduce

ansible-test integration old_style_cache_plugins --docker ubuntu2204 -vvv

Expected Results

Slow test run due to inline build of latest redis

Actual Results

Fast test run with minimal-to-no external deps

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Jul 21, 2023
@ansibot
Copy link
Contributor

ansibot commented Jul 21, 2023

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the component bot command.

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jul 25, 2023
Akasurde added a commit to Akasurde/ansible that referenced this issue Sep 15, 2023
* handle SyntaxWarning ini inventory parsing

Fixes: ansible#81328

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added the has_pr This issue has an associated PR. label Sep 15, 2023
@bcoca
Copy link
Member

bcoca commented Sep 18, 2023

main reason i wrote the 'pickle' caching pluing https://docs.ansible.com/ansible/latest/collections/community/general/pickle_cache.html

but in core you can just use the json one.

@bcoca bcoca closed this as completed in a1a6550 Sep 18, 2023
@Akasurde Akasurde reopened this Sep 18, 2023
@bcoca bcoca removed the has_pr This issue has an associated PR. label Sep 18, 2023
@bcoca
Copy link
Member

bcoca commented Sep 18, 2023

accidental close, forgot to rewrite commit comment

@s-hertel s-hertel self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

No branches or pull requests

6 participants