dnf module does not remove rpms from cache after installation

[opoplawski]

Summary

When the dnf module installs a new package or update, the rpm is left in /var/cache/dnf. This is unexpected since keepcache=false is the default for dnf which tells it to remove the rpm from the cache after installation.

Issue Type

Bug Report

Component Name

dnf

Ansible Version

$ ansible --version
ansible [core 2.16.0b2.post0] (stable-2.16 9c91e578d0) last updated 2023/10/11 11:49:36 (GMT -600)
  config file = /export/home/USER/ansible/ansible.cfg
  configured module search path = ['/export/home/USER/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /export/home/USER/ansible/lib/ansible
  ansible collection location = /export/home/USER/.ansible/collections:/usr/share/ansible/collections
  executable location = ./bin/ansible
  python version = 3.11.2 (main, Oct  5 2023, 18:41:49) [GCC 8.5.0 20210514 (Red Hat 8.5.0-18)] (/usr/bin/python3.11)
  jinja version = 3.1.2
  libyaml = True

Configuration

# if using a version older than ansible-core 2.12 you should omit the '-t all'
$ ansible-config dump --only-changed -t all
CONFIG_FILE() = /export/home/USER/ansible/ansible.cfg
DEFAULT_HOST_LIST(/export/home/USER/ansible/ansible.cfg) = ['/export/home/USER/ansi>
EDITOR(env: EDITOR) = vim
PAGER(env: PAGER) = less

SHELL:
=====

sh:
__
remote_tmp(/export/home/USER/ansible/ansible.cfg) = /tmp

OS / Environment

AlmaLinux 8.8

Steps to Reproduce

find /var/cache/dnf -name \*.rpm -delete
./bin/ansible -m dnf -a 'name=fpack state=present use_backend=dnf4' --user root HOSTNAME -vvv -e ansible_python_interpreter=/usr/bin/python3.11
find /var/cache/dnf -name \*.rpm

Expected Results

No rpm files in /var/cache.

Actual Results

/var/cache/dnf/epel-4e020062450c4732/packages/fpack-3.47-1.el8.x86_64.rpm

 SSH: EXEC ssh -C -o ControlMaster=auto -o ControlPersist=60s -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o 'User="root"' -o ConnectTimeout=10 -o 'ControlPath="/export/home/USER/.ansible/cp/317e511b29"' HOSTNAME '/bin/sh -c '"'"'rm -f -r /tmp/ansible-tmp-1697046623.8425725-490969-163230780326490/ > /dev/null 2>&1 && sleep 0'"'"''
<HOSTNAMEm> (0, b'', b'')
HOSTNAME | CHANGED => {
    "changed": true,
    "invocation": {
        "module_args": {
            "allow_downgrade": false,
            "allowerasing": false,
            "autoremove": false,
            "bugfix": false,
            "cacheonly": false,
            "conf_file": null,
            "disable_excludes": null,
            "disable_gpg_check": false,
            "disable_plugin": [],
            "disablerepo": [],
            "download_dir": null,
            "download_only": false,
            "enable_plugin": [],
            "enablerepo": [],
            "exclude": [],
            "install_repoquery": true,
            "install_weak_deps": true,
            "installroot": "/",
            "list": null,
            "lock_timeout": 30,
            "name": [
                "fpack"
            ],
            "nobest": false,
            "releasever": null,
            "security": false,
            "skip_broken": false,
            "sslverify": true,
            "state": "present",
            "update_cache": false,
            "update_only": false,
            "use_backend": "auto",
            "validate_certs": true
        }
    },
    "msg": "",
    "rc": 0,
    "results": [
        "Installed: fpack-3.47-1.el8.x86_64"
    ]
}

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibot]

Files identified in the description:

• lib/ansible/modules/dnf.py
• lib/ansible/plugins/action/dnf.py

If these files are incorrect, please update the component name section of the description or use the component bot command.

[opoplawski]

This also seems to happen with apt, at least with 2.14.11. But I imagine that should have its own report...

[mkrizek]

We might want to look at utilizing the dnf.Base.close() method: https://github.com/rpm-software-management/dnf/blob/2c1a38875e94353b0ff58b423340aca6441521ab/dnf/base.py#L531

[k4izyy]

Hi, can I be assigned to this issue?

[bcoca]

@KayZ4711 no need to assign, just open a PR and reference this issue in subjet with fixes #<issue number>

[Akasurde]

@k4izyy Are you working on this?

[k4izyy]

hi, i'm not working on this anymore. feel free to update

…

________________________________ From: Abhijeet Kasurde ***@***.***> Sent: Thursday, November 23, 2023 16:28 To: ansible/ansible ***@***.***> Cc: K4IS ***@***.***>; Mention ***@***.***> Subject: Re: [ansible/ansible] dnf module does not remove rpms from cache after installation (Issue #81954) @k4izyy<https://github.com/k4izyy> Are you working on this? — Reply to this email directly, view it on GitHub<#81954 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXMOXNGF3ITSZSMSJZSYG4TYF5TRFAVCNFSM6AAAAAA54MLOFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGYYTKOJTHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[voidquark]

Is there anyone working on this issue?