one or more %'s in /etc/ansible/facts.d value causes ansible_local to fail to load without error

[karlg100]

Summary

If a value in any local facts contains one or more "%" in the value, all ansilbe_local facts fails to populate. However, Ansible does not throw an error.

I'm unable to find this documented anywhere as expected behavior.

Issue Type

Bug Report

Component Name

local facts

Ansible Version

$ ansible --version
ansible [core 2.14.9]
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.9/site-packages/ansible
  ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/bin/ansible
  python version = 3.9.18 (main, Sep  7 2023, 00:00:00) [GCC 11.4.1 20230605 (Red Hat 11.4.1-2)] (/usr/bin/python3)
  jinja version = 3.1.2
  libyaml = True

Configuration

# if using a version older than ansible-core 2.12 you should omit the '-t all'
$ ansible-config dump --only-changed -t all
CONFIG_FILE() = /etc/ansible/ansible.cfg

OS / Environment

RHEL9

Steps to Reproduce

1. populate a working good local fact to /etc/ansible/facts.d/good.fact to cause ansible to populate ansible_local

[good fact]
value = this is a good fact

2. run ansible localhost -m ansible.builtin.setup -a 'filter=ansible_local' notice ansible_local["good"]["good fact"] is populated
3. populate bad local fact to /etc/ansible/facts.d/bad.fact

[bad fact]
value = this is a % bad % fact

4. rerun ansible localhost -m ansible.builtin.setup -a 'filter=ansible_local' and notice no more ansible_local facts

Expected Results

before bad fact:

# ansible localhost -m ansible.builtin.setup -a 'filter=ansible_local'
localhost | SUCCESS => {
    "ansible_facts": {
        "ansible_local": {
            "good": {
                "good fact": {
                    "value": "this is a good fact"
                }
            }
        }
    },
    "changed": false
}

after bad fact:

# ansible localhost -m ansible.builtin.setup -a 'filter=ansible_local'
localhost | SUCCESS => {
    "ansible_facts": {
        "ansible_local": {
            "good": {
                "good fact": {
                    "value": "this is a good fact"
                },
                "bad fact": {
                    "value": "this is a % bad % fact"
                }
            }
        }
    },
    "changed": false
}

Actual Results

before bad fact:

# ansible localhost -m ansible.builtin.setup -a 'filter=ansible_local'
localhost | SUCCESS => {
    "ansible_facts": {
        "ansible_local": {
            "good": {
                "good fact": {
                    "value": "this is a good fact"
                }
            }
        }
    },
    "changed": false
}

after bad fact:

localhost | SUCCESS => {
    "ansible_facts": {},
    "changed": false
}

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibot]

Files identified in the description:

• lib/ansible/plugins/connection/local.py
• lib/ansible/modules/setup.py

If these files are incorrect, please update the component name section of the description or use the component bot command.

[ansibot]

@karlg100 ansible-core 2.14 is not supported and no longer receives bug fixes. Please test against one of the supported versions of ansible-core, preferably the most recent one, to see whether the bug has been fixed.

click here for bot help

[karlg100]

reproduced on 2.15.9

# ansible --version
ansible [core 2.15.9]
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.9/site-packages/ansible
  ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/bin/ansible
  python version = 3.9.18 (main, Sep  7 2023, 00:00:00) [GCC 11.4.1 20230605 (Red Hat 11.4.1-2)] (/usr/bin/python3)
  jinja version = 3.1.3
  libyaml = True

# ansible localhost -m ansible.builtin.setup -a 'filter=ansible_local'
localhost | SUCCESS => {
    "ansible_facts": {},
    "changed": false
}

[karlg100]

tracked down to ConfigParser call in module_utils/facts/system/local.py

ansible/lib/ansible/module_utils/facts/system/local.py

Line 107 in 386edc6

val = cp.get(sect, opt)

when val = cp.get(sect, opt), the whole module fails without error. When running the module in debug mode, did get this error.

'%' must be followed by '%' or '(', found: '% bad % fact'