Improve ansible-galaxy handling of role versions #12904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willthames
force-pushed
the
galaxy_install_info_version
branch
from
0009a8e
to
780019c
Compare
willthames
force-pushed
the
galaxy_install_info_version
branch
from
780019c
to
4f0023f
Compare
| """ | ||
| if self.version: | ||
| return "%s (%s)" % (self.name, self.version) | ||
| else: |
There was a problem hiding this comment.
imho, this else is not usefull ?.
if self.version:
return xxxx
return xxxxThere was a problem hiding this comment.
@Lujeni meh, it's really not that important. I prefer it the way it is, and you're entitled to your preference.
Unless you can point to actual documentation backing up your preferences though (PEP-8, Ansible coding standards, etc.), I'm unlikely to change my code.
willthames
force-pushed
the
galaxy_install_info_version
branch
from
4f0023f
to
a2b7c7a
Compare
|
+1 |
Closed
|
This is helpful towards solving both #11266 and ansible/galaxy-issues#49 |
| @@ -318,3 +318,14 @@ def spec(self): | |||
| } | |||
| """ | |||
| return dict(scm=self.scm, src=self.src, version=self.version, name=self.name) | |||
|
|
|||
| @property | |||
| def version_string(self): | |||
There was a problem hiding this comment.
not really version_string .. full_name? name_and_version?
There was a problem hiding this comment.
I think this can be __repr__ rather than version_string :)
willthames
force-pushed
the
galaxy_install_info_version
branch
from
a2b7c7a
to
503a1cd
Compare
|
@bcoca should be ready for re-review now, I believe I've addressed your concerns. |
Ensure that role versions are considered when deciding whether or not to (re-)install a role. Issue a warning when the version of a dependency conflicts with the version of an already installed role Display what version of a role is being installed Show the versions when upgrading/downgrading a role. Implements ansible#11266
Ensure that force is required to change role versions
willthames
force-pushed
the
galaxy_install_info_version
branch
from
503a1cd
to
4945f41
Compare
ansibot
added
affects_2.3
ansibot
added
needs_rebase
ansibot
added
needs_revision
|
👋 apologies for the bump, but this PR deserves some attention as it implements a much requested feature. |
|
Ooh, it's merged! |
mscherer
added a commit
to mscherer/ansible
that referenced
this pull request
Apr 7, 2017
In current stable (2.2), ansible galaxy install --force do erase a role, even if the version is not set. This commit should restore that specific behavior, in accordance to people reports: ansible#11266 (comment) It was also the behavior planned in the initial discussion: "if you're not fixing versions in your roles file, then it's fine to expect that the role will be reinstalled each time you run ansible-galaxy install.", cf ansible#12904
chouseknecht
pushed a commit
that referenced
this pull request
Apr 21, 2017
In current stable (2.2), ansible galaxy install --force do erase a role, even if the version is not set. This commit should restore that specific behavior, in accordance to people reports: #11266 (comment) It was also the behavior planned in the initial discussion: "if you're not fixing versions in your roles file, then it's fine to expect that the role will be reinstalled each time you run ansible-galaxy install.", cf #12904
abadger
pushed a commit
that referenced
this pull request
Jun 7, 2017
In current stable (2.2), ansible galaxy install --force do erase a role, even if the version is not set. This commit should restore that specific behavior, in accordance to people reports: #11266 (comment) It was also the behavior planned in the initial discussion: "if you're not fixing versions in your roles file, then it's fine to expect that the role will be reinstalled each time you run ansible-galaxy install.", cf #12904 (cherry picked from commit 78836ec)
ansibot
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that role versions are considered when deciding
whether or not to (re-)install a role.
Issue a warning when the version of a dependency conflicts
with the version of an already installed role
Display what version of a role is being installed
Show the versions when upgrading/downgrading a role.
Implements #11266
Note that the behaviour with galaxy roles with an unspecified version is a little odd. This is because
meta/.galaxy_install_infogets told the version of the role that actually gets installed when installing under galaxy. However, if you're not fixing versions in your rolesfile, then it's fine to expect that the role will be reinstalled each time you run ansible-galaxy install. (This is similar to the behaviour ofyum state=latest, for example). One fix for this would be for.galaxy_install_infoto be told the version of the role specified, rather than the version of the role installed.