Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_regedit integration test to cover change to allow empty string comparison #15570

Merged

Conversation

jhawkesworth
Copy link
Contributor

ISSUE TYPE
  • Bugfix Pull Request
ANSIBLE VERSION
ansible 2.1.0 (devel ba74f5f3e5) last updated 2016/04/20 23:46:56 (GMT +100)
  lib/ansible/modules/core: (devel 36755e5fe2) last updated 2016/04/24 16:06:03 (GMT +100)
  lib/ansible/modules/extras: (devel de22b721db) last updated 2016/04/24 16:03:40 (GMT +100)
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

SUMMARY

Add integration test to ensure empty strings, which are legitimate registry data entry values to be compared.

See the conversation on ansible/ansible-modules-extras#2034 for background.

Test covers the fix in ansible/ansible-modules-extras@7d9b73e (which was accidentally pushed straight to devel instead of via a PR

n/a only affects integration test output for make test_winrm -t test_win_regedit

@jhawkesworth jhawkesworth self-assigned this Apr 24, 2016
@jhawkesworth jhawkesworth added the windows Windows community label Apr 24, 2016
@nitzmahone nitzmahone merged commit ca5080d into ansible:devel Apr 29, 2016
@jhawkesworth jhawkesworth deleted the regedit_fix_str_compare_tests branch May 4, 2016 06:55
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants