Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the module snippet to python3 #15870

Merged
merged 1 commit into from
May 16, 2016
Merged

Port the module snippet to python3 #15870

merged 1 commit into from
May 16, 2016

Conversation

mscherer
Copy link
Contributor

ISSUE TYPE
  • Feature Pull Request
SUMMARY

vca depend on pyvcloud, who depend on PyYAML 3.10, which
support python 2.5 as a minimum, cf https://github.com/vmware/pyvcloud/blob/master/requirements.txt
and http://pyyaml.org/wiki/PyYAML

vmware.py depend on PyVIM, who depend on python 2.6.

So we can use the modern syntax for both of them.

@mscherer
Port the module snippet to python3
7aaacd3 
vca depend on pyvcloud, who depend on PyYAML 3.10, which
support python 2.5 as a minimum, cf https://github.com/vmware/pyvcloud/blob/master/requirements.txt
and http://pyyaml.org/wiki/PyYAML

vmware.py depend on PyVIM, who depend on python 2.6.

So we can use the modern syntax for both of them.
@mscherer
Copy link
Contributor Author

So travis failed due to:

@bcoca bcoca added this to the 2.2.0 milestone May 16, 2016
@bcoca bcoca merged commit 127a37f into ansible:devel May 16, 2016
mscherer added a commit to mscherer/ansible that referenced this pull request May 16, 2016
@mscherer
Do not test vca and vmware.py for py2.4
e5a69d1 
Since both of them depend on libraries not
working on python 2.4, we shouldn't restrict
ourself on 2.4, cf ansible#15870
@mscherer mscherer mentioned this pull request May 16, 2016
Merged
bcoca pushed a commit that referenced this pull request May 16, 2016
@mscherer @bcoca
Do not test vca and vmware.py for py2.4 (#15887)
cc61531 
Since both of them depend on libraries not
working on python 2.4, we shouldn't restrict
ourself on 2.4, cf #15870
mscherer added a commit to mscherer/ansible-modules-extras that referenced this pull request May 16, 2016
@mscherer
Port vca_nat and vca_fw to py3 compatible syntax
ea2dc21 
Since they both depend on library that cannot run on python2.4,
cf ansible/ansible#15870, we can use
directly the python 2.6 syntax, as seen on the porting doc.
@mscherer mscherer mentioned this pull request May 16, 2016
Merged
mscherer added a commit to mscherer/ansible-modules-extras that referenced this pull request May 17, 2016
@mscherer
Port vca_nat and vca_fw to py3 compatible syntax
3c6de32 
Since they both depend on library that cannot run on python2.4,
cf ansible/ansible#15870, we can use
directly the python 2.6 syntax, as seen on the porting doc.
abadger pushed a commit to ansible/ansible-modules-extras that referenced this pull request May 17, 2016
@mscherer @abadger
Port vca_nat and vca_fw to py3 compatible syntax (#2243)
84ec0c8 
Since they both depend on library that cannot run on python2.4,
cf ansible/ansible#15870, we can use
directly the python 2.6 syntax, as seen on the porting doc.
gedl pushed a commit to gedl/ansible-modules-extras that referenced this pull request May 24, 2016
@mscherer @gedl
Port vca_nat and vca_fw to py3 compatible syntax (ansible#2243)
034d4aa 
Since they both depend on library that cannot run on python2.4,
cf ansible/ansible#15870, we can use
directly the python 2.6 syntax, as seen on the porting doc.
mattclay pushed a commit that referenced this pull request Jun 7, 2016
@mscherer @mattclay
Do not test vca and vmware.py for py2.4 (#15887)
86516ea 
Since both of them depend on libraries not
working on python 2.4, we shouldn't restrict
ourself on 2.4, cf #15870
(cherry picked from commit cc61531)
cinek810 pushed a commit to cinek810/ansible-modules-extras that referenced this pull request Jun 12, 2016
@mscherer
Port vca_nat and vca_fw to py3 compatible syntax (ansible#2243)
140f94e 
Since they both depend on library that cannot run on python2.4,
cf ansible/ansible#15870, we can use
directly the python 2.6 syntax, as seen on the porting doc.
Qalthos pushed a commit to Qalthos/ansible that referenced this pull request Jun 13, 2016
@mscherer @Qalthos
Port the module snippet to python3 (ansible#15870)
f05c046 
vca depend on pyvcloud, who depend on PyYAML 3.10, which
support python 2.5 as a minimum, cf https://github.com/vmware/pyvcloud/blob/master/requirements.txt
and http://pyyaml.org/wiki/PyYAML

vmware.py depend on PyVIM, who depend on python 2.6.

So we can use the modern syntax for both of them.
Qalthos pushed a commit to Qalthos/ansible that referenced this pull request Jun 15, 2016
@mscherer @Qalthos
Port the module snippet to python3 (ansible#15870)
9c9fcc4 
vca depend on pyvcloud, who depend on PyYAML 3.10, which
support python 2.5 as a minimum, cf https://github.com/vmware/pyvcloud/blob/master/requirements.txt
and http://pyyaml.org/wiki/PyYAML

vmware.py depend on PyVIM, who depend on python 2.6.

So we can use the modern syntax for both of them.
Constantin07 pushed a commit to Constantin07/ansible-modules-extras that referenced this pull request Jun 28, 2016
@mscherer @Constantin007
Port vca_nat and vca_fw to py3 compatible syntax (ansible#2243)
b2af713 
Since they both depend on library that cannot run on python2.4,
cf ansible/ansible#15870, we can use
directly the python 2.6 syntax, as seen on the porting doc.
haad pushed a commit to haad/ansible-modules-extras that referenced this pull request Jun 29, 2016
@mscherer
Port vca_nat and vca_fw to py3 compatible syntax (ansible#2243)
f56c767 
Since they both depend on library that cannot run on python2.4,
cf ansible/ansible#15870, we can use
directly the python 2.6 syntax, as seen on the porting doc.
perzizzle pushed a commit to perzizzle/ansible-modules-extras that referenced this pull request Jul 12, 2016
@mscherer
Port vca_nat and vca_fw to py3 compatible syntax (ansible#2243)
42dcf6c 
Since they both depend on library that cannot run on python2.4,
cf ansible/ansible#15870, we can use
directly the python 2.6 syntax, as seen on the porting doc.
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mscherer @jimi-c @bcoca @ansibot