Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter tags #16143

Closed
wants to merge 1 commit into from
Closed

Filter tags #16143

wants to merge 1 commit into from

Conversation

jordiclariana
Copy link

ISSUE TYPE
  • Feature Pull Request
ANSIBLE VERSION
ansible 2.1.0.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
SUMMARY

Add filter_tags option to filter tags after retrieve them.

This is complement to instance_filters which can only do OR when it have more than one rule.
This filter will be executed after retrieving all tags (instance_filters is send with the
AWS API call so the instances are filtered server-side). only if all tags specified exist
and the value of the tag match they will be included in the final list.

@alikins alikins added this to the 2.2.0 milestone Jun 6, 2016
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 13, 2016
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 21, 2016
@jordiclariana
Add filter_tags option to filter tags after retrieve them.
8ac6c29 
This is complement to instance_filters which can only do OR when it have more than one rule.
This filter will be executed after retrieving all tags (instance_filters is send with the
AWS API call so the instances are filtered server-side). only if all tags specified exist
and the value of the tag match they will be included  in the final list.
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 8, 2017
@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2017

cc @willthames
click here for bot help

@s-hertel s-hertel added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 5, 2017
@ansibot
Copy link
Contributor

ansibot commented Apr 5, 2017

@jordiclariana Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • component name

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Apr 5, 2017
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Apr 13, 2017
@gundalow gundalow modified the milestone: 2.2.0 Apr 13, 2017
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@ansibot ansibot added the inventory Inventory category label Jul 19, 2017
@calfonso calfonso added the discussion_topic This issue/PR includes a topic that requires a deeper discussion. Maybe raise this in a meeting? label Jul 24, 2017
@ansibot
Copy link
Contributor

ansibot commented Sep 7, 2017

cc @ryansb @s-hertel
click here for bot help

@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 7, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@s-hertel
Copy link
Contributor

Hi, @jordiclariana. We are not working on adding features to the inventory scripts since adding the inventory plugins (new in Ansible 2.4). I think this is something you can already do with the aws_ec2 inventory plugin using the constructed option keyed_groups. Feel free to reach out if you have questions.

@s-hertel s-hertel closed this Nov 16, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 aws c:inventory/contrib_script cloud discussion_topic This issue/PR includes a topic that requires a deeper discussion. Maybe raise this in a meeting? feature This issue/PR relates to a feature request. inventory Inventory category needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jordiclariana @ansibot @s-hertel @calfonso @alikins @gundalow @jctanner