Fix for issue @synchronize doesn't substitute variables properly #16347

[ovcharenko]

ISSUE TYPE

• Bugfix Pull Request

ANSIBLE VERSION

ansible 2.1.0.0
  config file = /tmp/ansible.cfg
  configured module search path = Default w/o overrides

SUMMARY

Fixes #16347: use proper ansible_ssh_private_key_file formatting.

Now test playbook works just fine:
$ ansible-playbook test.yaml

PLAY [SSH test] ****************************************************************

TASK [setup] *******************************************************************
ok: [XXX.compute-1.amazonaws.com]

TASK [ping] ********************************************************************
ok: [XXX.compute-1.amazonaws.com -> localhost]

TASK [synchronize] *************************************************************
changed: [XXX.compute-1.amazonaws.com]

PLAY RECAP *********************************************************************
XXX.compute-1.amazonaws.com : ok=3    changed=1    unreachable=0    failed=0

[ovcharenko]

Wish we had faster development here...

[tima]

Sorry @ovcharenko been kind of buried here to test this. Trying to verify it myself now and with the core team.

[abadger]

What's the purpose of using format() here? Is it adding anything useful?

[ovcharenko]

That could be removed.

[abadger]

@bcoca looked at the first part of the fix and thinks that it is correct to look in play_context for the value so that seems correct.

The format() portion seems like it won't do anything here. So maybe that's just been left in from debugging and should be removed?