Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a unicode problem when parsing playbooks #16507

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Jun 29, 2016

ISSUE TYPE
  • Bugfix Pull Request
ANSIBLE VERSION
ansible-1.9.5
SUMMARY

Fixes #16373

@abadger abadger added this to the stable-1.9 milestone Jun 29, 2016
@abadger abadger added bugfix_pull_request easyfix This issue is considered easy to fix by aspiring contributors. labels Jun 29, 2016
@abadger
Copy link
Contributor Author

abadger commented Jun 29, 2016

@simfarm -- give this a try and see if it fixes your problem. Note that 1.9 is in security fix mode now so we'll have to discuss as a team whether to accept this change or not. It's only a few lines of change but there's always a danger of regressions being introduced... when pushing releases for a security-only branch the last thing you want is for regressions unrelated to any security fixes to appear. You should be able to copy this change over to your own copy of ansible-1.9 if it works for you and you need it.

Since this is fixed in ansible-2.x migrating to that is also an option.

@simfarm
Copy link

simfarm commented Jun 30, 2016

@abadger Thank you for this fix Toshio! I can't speak for a regression perspective, but this fix does indeed fix our unicode test fail.

What are next steps - run integration against a release candidate?

@bcoca bcoca merged commit 5ed3f94 into ansible:stable-1.9 Jun 30, 2016
@abadger abadger deleted the 1.9-unicode-fix branch June 30, 2016 16:09
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. easyfix This issue is considered easy to fix by aspiring contributors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants