Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent JSON output on verbose #16838

Closed
wants to merge 1 commit into from
Closed

Conversation

jpic
Copy link
Contributor

@jpic jpic commented Jul 27, 2016

As discussed on the Improving default output thread, this PR enables output indentation with only -v.

@bcoca
Copy link
Member

bcoca commented Jul 27, 2016

I would not make this change for all users, many prefer the condensed output and will use higher verbosity if they need to really check the large json outputs.

It would be better to make it configurable and keep the current default.

@bcoca bcoca added feature_pull_request needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 27, 2016
@jpic
Copy link
Contributor Author

jpic commented Jul 27, 2016

Perhaps we could make a new option, such as '--readable' ?

Should I group both PRs ?

@bcoca
Copy link
Member

bcoca commented Jul 27, 2016

separate is fine, i would not want another command line option, using config should be enough, either through ansible.cfg or environment variable.

@jpic
Copy link
Contributor Author

jpic commented Jul 27, 2016

The environment variable is a very good idea. ANSIBLE_READABLE ?

@bcoca
Copy link
Member

bcoca commented Jul 27, 2016

bikeshedding now: ANSIBLE_INDENT_VERBOSITY

@jpic
Copy link
Contributor Author

jpic commented Jul 27, 2016

Well, dunno if it's bikeshedding since we're going to have to live with this for the rest of our lifes or something :p What I don't like with INDENT_VERBOSITY is that I don't understand what it means as a non native speaker, perhaps it's possible to find a more representative name in one word if possible ?

I'm updating the branch for config/env var support

@jpic jpic mentioned this pull request Jul 27, 2016
@jpic
Copy link
Contributor Author

jpic commented Jul 27, 2016

Closing in favor of #16839 which adds a debug callback that does the same.

@jpic jpic closed this Jul 27, 2016
@jimi-c jimi-c removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 27, 2016
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants